525419 - DBViewWrapper.clone does not noteCuriosity for cloned search/synthetic (gloda-backed) views

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

While inspecting code for bug 498141 I noticed that we always stalkFolders in DBViewWrapper.clone and do not noteCuriosity which is required for the view to get the deletion events it needs.  I'm not sure how much of a problem this actually is for the standalone message views given that you can't see the view, but clone should do the correct thing anyways.

Speculatively assigning to bienvenu and requesting blocking.  (It's probably easier to fix this than to figure out if there are cases where things can go wrong.)

Comment 1

[David :Bienvenu]

Attachment: proposed fix

I verified that this notes curiosity when you open messages from search results and gloda search results in a new tab. 

the bug the curious wrappers fixed had to do with loading the next message after deleting a message, and that seems to work with a message loaded into a tab from a gloda search results view.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 409436 [details] [diff] [review]
proposed fix

Thank you for taking care of this.

I verified (by inspection) that calling stalkFolders with no interests does not do anything bad to the state, which was my only concern.

Comment 3

[David :Bienvenu]

fixed on trunk and branch