525532 - reply all is shown when your email is in wrong case

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Some systems insist on sending mail to you using ALL CAPS case or similar. For such emails the Reply All is shown. It should not.

Yeah emails are case-sensitive in theory, but theory only.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 409390 [details] [diff] [review]
proposed fix

>   let myEmail = getIdentityForHeader(msgHdr).email;

I'ld prefer you put the ".toLowerCase()" up on this line, since...

[snip]
>-  let imInAddresses = addresses.indexOf(myEmail) != -1;
>+  let imInAddresses = addresses.toLowerCase().indexOf(myEmail.toLowerCase()) != -1;

this is the only place we use the myEmail variable, and this line is just a little longer than 80 characters if you do it down here.  ;)

r=me, though, with or without that change.

And I'm asking for approval because it's a very small change, with low risk of breaking anything, that will make a sort-of-small number of users happier.

Thanks,
Blake.

Comment 2

[Arthur Hagen]

But I have two e-mail accounts, one named art@... and one named ART@...
What if I want to move the conversation over to art@...?

Leave well enough alone, or, better yet, always show the "reply all".
Automated predictions will always fail to predict what the users want in SOME cases, and it's anyhow usually better to be consistent, even when it means more clutter.

Comment 3

[Magnus Melin [:mkmelin]]

So are you saying you have two actual accounts for that? (=emails differ only by case, go to different accounts on the server.) You'd be the first i've heard of!
For the absolute majority of users, you'd not want to reply to yourself too when replying.

Anyway, this patch only actually changes things when YOU're the single recipient. In case a mail is to YOU and someone else the reply button is shown (like before).

Comment 4

[Jim Porter (:squib)]

For what it's worth, I've only ever seen improper case in the domain-part of the email address. That's a bit harder to check for, though.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2 (for checkin)

Carrying forward r=bwinton

Requesting approval; well contained small patch

Comment 6

[Magnus Melin [:mkmelin]]

changeset:   4322:d2b4b4a521d3
http://hg.mozilla.org/comm-central/rev/d2b4b4a521d3

changeset:   4299:057597d6ad0d
http://hg.mozilla.org/releases/comm-1.9.1/rev/057597d6ad0d

->FIXED