525628 - [Windows XP classic theme] Mouse hovering on "Other actions" button, resize message header height in some cases

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[[:Aureliano Buendía]]

Attachment: testcase email

It seems that happens when subject of the mail is wrap and in 2 line there is a "-".

I have my TB on Windows XP that use also lightning with today pane displayed.

In attached screenshot1 you can see as is the wrap statu of the mail testcase that I have attached: when mouse over the button, the message header pane is resize to minor height and the subject not is wrapped. When mouse over end the size is restored to original measure.

I can't provide a closely STR: but using email testcase attached in scenario descibed in screenshot1, you should reproduce (I hope) scenario descrived in screenshot2.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091031 Lightning/1.0pre Shredder/3.0pre ID:20091031032222

This bug should be block TB 3? Probably not but I set blocking? for more emphasys.

Comment 1

[[:Aureliano Buendía]]

Attachment: screenshot1

Comment 2

[[:Aureliano Buendía]]

Attachment: screenshot2

mumble: could be related to lightining?

Comment 3

[[:Aureliano Buendía]]

Test also in safe-mode: not issue related to lightning.

I can provide a STR:

1. open TB in safe-mode and goto view "all folders";
2. open enail testcase attached here and edit as new as save it as draft;
3. goto in draft folder where the testcase is stored and enabled message pane view;
4. drag splitter between folders pane and other section until the subject ("[Bug 474701] gloda global search on toolbar, folder display refactoring mega-bug") of testcase is wrap in 2 lines: it is important that drag end immediately when subject is wrap.
5. now overing with the mouse on button and you can see screenshot2 scenario.

Comment 4

[[:Aureliano Buendía]]

>It seems that happens when subject of the mail is wrap and in 2 
>line there is a "-".

This is false: the issue affect all long subject email.

Comment 5

[Ben Bucksch (:BenB)]

Can't reproduce (Linux).

Comment 6

[[:Aureliano Buendía]]

(In reply to comment #5)
> Can't reproduce (Linux).
Confirmed: can't reproduce on ubuntu 9.10... it seems only windows related!

Comment 7

[Jim Porter (:squib)]

You're using the Classic theme, right? The size of the button border is slightly smaller in Classic than Luna/etc, and the CSS for the "other actions" button sets the border to 3px (the Luna size), and when you mouse over it, the border gets forced to be 2px by way of XUL. There's another bug that mentions this, but I can't find it.

Comment 8

[[:Aureliano Buendía]]

Yes it is Jim: it seems to affect only windows xp classic theme and not luna theme.

Comment 9

[Andreas Nilsson (:andreasn)]

seems like my area

Comment 10

[David Ascher (:davida)]

Annoying, but not blocking.

Comment 12

[rsx11m]

Attachment: Screenshot showing 3-line case

I'm reposting this from bug 526646 comment #1 to have all the cases in one place. As you can see, the splitter and message move up by 2px when hovering, and the "other actions" label moves up 1px and to the right 1px. The latter would support comment #7, meaning the button border is loosing 1px when the border is shown on hovering.

In contrast to the original description here and STR in comment #3, I do *not* see this in cases where the subject line wraps, hovering over the button retains the current header-pane height and wrapping status.

I can also confirm comment #6, no issue with the gnomestripe theme on KDE 3.5.

Comment 13

[rsx11m]

> In attached screenshot1 you can see as is the wrap statu of the mail testcase
> that I have attached: when mouse over the button, the message header pane is
> resize to minor height and the subject not is wrapped.

I think I have an explanation for the wrapping/no-wrapping case here. The width of the subject box is limited by the button box, thus the "mega-wrap" goes into the next line. When hovering over the "other actions" button, it shrinks by 2px in width, thus allowing the subject box to expand by 2px. Coincidentally, the subject now fits into a single line and is no longer wrapped.

Aureliano, if you increase or decrease the width of your window by more than 2px you should see the wrapping either disappear or present in both states.

Comment 14

[[:Aureliano Buendía]]

(In reply to comment #13)
> Aureliano, if you increase or decrease the width of your window by more than
> 2px you should see the wrapping either disappear or present in both states.

Yes it is: in comment #3 I says:
> it is important that drag end immediately when subject is wrap.
You have right this "immediately" is 2 px.

Comment 15

[rsx11m]

Ok, now I understand your steps to reproduce better. Thus, it's all indeed caused by the button shrinking when it gets a border with the Classic theme.

To avoid that, would it be possible to put a box around the menu button and force that box to have a specific height rather than the button itself?

Comment 16

[Jim Porter (:squib)]

Width is also an issue, which will be dependent on localization, etc. One solution would be to put the current button in a deck with an invisible duplicate button behind it (always using the moused-over style), and then just center the visible button. Then we don't have to worry about border size at all.

Comment 17

[Ben Bucksch (:BenB)]

Things should not change their size on hover. Reason is that it would exactly cause things like this - you have the same problem on the web.
Solution is to make sure that the hover state has the exact same size as the non-hover state, e.g. by not adding or removing borders.

Comment 19

[Markus Fischer]

Experiencing the same issue here, classic theme. Can't find a relation to long subject lines.

Comment 22

[Ludovic Hirlimann [:Usul]]

A solution is to install https://addons.mozilla.org/de/thunderbird/addon/13564 .

Comment 23

[denis.barmenkov]

(In reply to comment #22)
> A solution is to install https://addons.mozilla.org/de/thunderbird/addon/13564
> .

It is not true: solution is a good working TB.

Comment 24

[Ben Bucksch (:BenB)]

Tsk meant "workaround", not "solution". (He's not a native english speaker, so be easy with him.)

Comment 25

[denis.barmenkov]

(In reply to comment #24)
> Tsk meant "workaround", not "solution". (He's not a native english speaker, so
> be easy with him.)

Thank you for explanation.
I'm not English speaker too :).

Comment 26

[Michael Venables]

I've been battling this bug for awhile and have some additional info to contribute. The info already posted points to XP running with the classic UI -- which was the one element I couldn't pin down.

What I noticed doesn't have anything to do with the length of the message subject, but rather the number of addressees. If there's only one addressee, the message header panel shrinks when the "other actions" button is "painted in" on hover. If there is more than one addressee -- i.e. two or more addressee lines -- the problem does not occur.

Comment 27

[rsx11m]

(In reply to comment #22)
> A [workaround] is to install https://addons.mozilla.org/thunderbird/addon/13564

Apparently herb has solved the problem by moving the "other actions" into the header-pane toolbar with all the other buttons. While that's an idea, it would increase issues with narrow windows and the buttons running into the "from:" header filed (bug 520249). So that wouldn't work with its current position.

Comment 28

[Ludovic Hirlimann [:Usul]]

Mass move to the new theme component.

Comment 29

[dagger.bugzilla]

Attachment: Use 2px border on Windows Classic

I'd say the best way to fix this is to make the button look like a button, rather than try to give it a custom appearance and then be surprised when we stuff it up.

But failing that, here's a patch that sets the border to 2px instead of 3px, preventing the button size from changing on mouse-over under :-moz-system-metric(windows-classic).

Comment 30

[Andreas Nilsson (:andreasn)]

I could not get this patch to function properly on my Win7 box. Adding -moz-appearance: none; helped some, but I suspect there are some other properties interfering here.

Comment 31

[dagger.bugzilla]

Attachment: Use 2px border on Windows Classic v2

Ah, it looks like Thunderbird uses messageHeader.css from skin/classic/aero/ on Windows 7, even when Aero is disabled. (It's possible to trick it into not doing that by running under compatibility mode: Right click the Thunderbird shortcut > Properties > Compatibility > Run in compatibility mode for Windows XP.)

This patch places the rule in the aero version of messageHeader.css too.

Comment 32

[Andreas Nilsson (:andreasn)]

Comment on attachment 590996 [details] [diff] [review]
Use 2px border on Windows Classic v2

Aha, that did the trick!
review+!

Comment 33

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/81005ca68455