525893 - Add historical changes in rank to top crash reports

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Austin King [:ozten]]

Bug#411397 will track short term changes to display rank.

This bug will track changes that use the new rank/trend REST api being built in Bug#523653.

Comment 1

[Austin King [:ozten]]

Attachment: First stab at adding change in rank

currently topcrashers/byversion and topcrashers/bybranch work very similarly. This patch incorporates the new sorocco web service for data access on byversion. The bybranch uses the "old" db access and doesn't have the new rank data.

This patch adds a Web_Service class and changes the way CSV output is formatted.

Comment 2

[Austin King [:ozten]]

note: the patch contains webserviceclient.php-dist. Copy this config file.
Also missing are two images, which you can grab off khan.
cp /home/aking/breakpad/socorro-orig/webapp-php/img/*_arrow.png webapp-php-img/

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 415404 [details] [diff] [review]
First stab at adding change in rank

Good work Austin.  I'm including a few minor notes below, but this is could go as is.  


== byversion() ==

The following should probably be in config files:
* $cache_in_minutes = 12;
* $dur = $duration * 60;
* $lifetime = $cache_in_minutes * 60;

_ensureProperties() needs header documentation.

== Web_Service.php ==

I like the separate WebService library you created.  We should make a note to refactor models/extension.php to use that library as well.

Comment 4

[Austin King [:ozten]]

Attachment: First stab at adding a plot to top crashers page

Sorry for the dirty patch, I'm blocked on checking in attachement#415404.

This patch uses the 2nd new backend API which provides historical data suitable for plotting. It's not as polished as I'd like, but might be more useful than nothing. When you click on a table cell, it plots the signature over the last couple of days in terms of crash count and % of total crashes.

Comment 5

[Austin King [:ozten]]

Attachment: Screenshot of first plot patch

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 415536 [details] [diff] [review]
First stab at adding a plot to top crashers page

I'm not sure how to test this.  But I don't see anything in the patch that is a cause for concern.

Comment 7

[Austin King [:ozten]]

Sending        webapp-php/application/cache
Sending        webapp-php/application/config
Sending        webapp-php/application/config/webserviceclient.php-dist
Sending        webapp-php/application/controllers/mtbf.php
Sending        webapp-php/application/controllers/topcrasher.php
Sending        webapp-php/application/libraries/MY_Controller.php
Adding         webapp-php/application/libraries/Web_Service.php
Adding         webapp-php/application/libraries/timeutil.php
Adding         webapp-php/application/views/common/csv.php
Adding         webapp-php/application/views/common/data_access_error.php
Sending        webapp-php/application/views/common/list_topcrashers.php
Adding         webapp-php/application/views/common/list_topcrashers_old.php
Deleting       webapp-php/application/views/mtbf/of_csv.php
Sending        webapp-php/application/views/topcrasher/bybranch.php
Deleting       webapp-php/application/views/topcrasher/bybranch_csv.php
Sending        webapp-php/application/views/topcrasher/byversion.php
Deleting       webapp-php/application/views/topcrasher/byversion_csv.php
Adding         webapp-php/application/views/topcrasher/byversion_old.php
Sending        webapp-php/css/screen.css
Adding  (bin)  webapp-php/img/down_arrow.png
Adding  (bin)  webapp-php/img/up_arrow.png
Sending        webapp-php/js/socorro/topcrash.js
Adding         webapp-php/tests/TimeUtilTest.php
Transmitting file data ..................
Committed revision 1539.