Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Rename communicator-overlay-preferences.xul to suite-overlay-preferences.xul

RESOLVED FIXED in 1.0b1

Status

Calendar
Lightning: SeaMonkey Integration
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Saint Wesonga)

Tracking

Bug Flags:
in-testsuite -

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.65 KB, patch
martinschroeder
: review+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
From Bug #518865:

Martin Schröder:
> One nit: We have
> suite-overlay-messenger.xul and communicator-overlay-preferences.xul in
> lightning/content with this patch. You should decide which prefix SeaMonkey
> related files should use, suite or communicator.

Robert Kaiser:
> I'd prefer to go for suite everywhere, communicator is a Netscape-ism only,
> IMHO.
(Assignee)

Comment 1

8 years ago
Created attachment 410407 [details] [diff] [review]
Patch
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #410407 - Flags: review?(neil)
(Reporter)

Comment 2

8 years ago
Comment on attachment 410407 [details] [diff] [review]
Patch

Looks good but I read somewhere that hg import/qimport doesn't handle git style patches that contain moves/renames. Since I've never tried this, please take this comment with a pinch of salt.

Updated

8 years ago
Attachment #410407 - Flags: review?(neil) → review+
Comment on attachment 410407 [details] [diff] [review]
Patch

You need Calendar team review for this patch! Please, sort the jar.mn entry alphabetically (although it haven't been before). r=mschroeder with nit fixed.
Attachment #410407 - Flags: review+
(Assignee)

Comment 4

8 years ago
Created attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]
Attachment #411884 - Flags: review?(mschroeder)
Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]

r=mschroeder
Attachment #411884 - Flags: review?(mschroeder) → review+
Attachment #410407 - Attachment is obsolete: true
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]


http://hg.mozilla.org/comm-central/rev/3c8754cfd6be
Attachment #411884 - Attachment description: Patch with nit fixed → Patch with nit fixed [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [c-n: c-1.9.1]
For comm-1.9.1:
http://hg.mozilla.org/releases/comm-1.9.1/rev/450ae7b55645
http://hg.mozilla.org/releases/comm-1.9.1/rev/f42153972700
Keywords: checkin-needed
Whiteboard: [c-n: c-1.9.1]
Target Milestone: --- → 1.0
Attachment #411884 - Attachment description: Patch with nit fixed [Checkin: Comment 6] → Patch with nit fixed [Checkin: Comment 6 & 7]
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.