526172 - Rename communicator-overlay-preferences.xul to suite-overlay-preferences.xul

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Philip Chee]

From Bug #518865:

Martin Schröder:
> One nit: We have
> suite-overlay-messenger.xul and communicator-overlay-preferences.xul in
> lightning/content with this patch. You should decide which prefix SeaMonkey
> related files should use, suite or communicator.

Robert Kaiser:
> I'd prefer to go for suite everywhere, communicator is a Netscape-ism only,
> IMHO.

Comment 1

[Saint Wesonga]

Attachment: Patch

Comment 2

[Philip Chee]

Comment on attachment 410407 [details] [diff] [review]
Patch

Looks good but I read somewhere that hg import/qimport doesn't handle git style patches that contain moves/renames. Since I've never tried this, please take this comment with a pinch of salt.

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 410407 [details] [diff] [review]
Patch

You need Calendar team review for this patch! Please, sort the jar.mn entry alphabetically (although it haven't been before). r=mschroeder with nit fixed.

Comment 4

[Saint Wesonga]

Attachment: Patch with nit fixed [Checkin: Comment 6 & 7]

Comment 5

[Martin Schröder [:mschroeder]]

Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]

r=mschroeder

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]


http://hg.mozilla.org/comm-central/rev/3c8754cfd6be

Comment 7

[Martin Schröder [:mschroeder]]

For comm-1.9.1:
http://hg.mozilla.org/releases/comm-1.9.1/rev/450ae7b55645
http://hg.mozilla.org/releases/comm-1.9.1/rev/f42153972700

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".