Closed Bug 526172 Opened 10 years ago Closed 10 years ago

Rename communicator-overlay-preferences.xul to suite-overlay-preferences.xul

Categories

(Calendar :: Lightning: SeaMonkey Integration, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: wesongathedeveloper)

References

Details

Attachments

(1 file, 1 obsolete file)

From Bug #518865:

Martin Schröder:
> One nit: We have
> suite-overlay-messenger.xul and communicator-overlay-preferences.xul in
> lightning/content with this patch. You should decide which prefix SeaMonkey
> related files should use, suite or communicator.

Robert Kaiser:
> I'd prefer to go for suite everywhere, communicator is a Netscape-ism only,
> IMHO.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #410407 - Flags: review?(neil)
Comment on attachment 410407 [details] [diff] [review]
Patch

Looks good but I read somewhere that hg import/qimport doesn't handle git style patches that contain moves/renames. Since I've never tried this, please take this comment with a pinch of salt.
Attachment #410407 - Flags: review?(neil) → review+
Comment on attachment 410407 [details] [diff] [review]
Patch

You need Calendar team review for this patch! Please, sort the jar.mn entry alphabetically (although it haven't been before). r=mschroeder with nit fixed.
Attachment #410407 - Flags: review+
Attachment #411884 - Flags: review?(mschroeder)
Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]

r=mschroeder
Attachment #411884 - Flags: review?(mschroeder) → review+
Attachment #410407 - Attachment is obsolete: true
Keywords: checkin-needed
Comment on attachment 411884 [details] [diff] [review]
Patch with nit fixed
[Checkin: Comment 6 & 7]


http://hg.mozilla.org/comm-central/rev/3c8754cfd6be
Attachment #411884 - Attachment description: Patch with nit fixed → Patch with nit fixed [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [c-n: c-1.9.1]
Attachment #411884 - Attachment description: Patch with nit fixed [Checkin: Comment 6] → Patch with nit fixed [Checkin: Comment 6 & 7]
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.