The default bug view has changed. See this FAQ.

Calendar Properties item missing from the SeaMonkey Edit menu.

RESOLVED FIXED in 1.0b1

Status

Calendar
Lightning: SeaMonkey Integration
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Dependency tree / graph

Details

(Whiteboard: [comm-1.9.1 only])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
http://mxr.mozilla.org/comm-central/source/calendar/lightning/content/messenger-overlay-sidebar.xul#125

Thunderbird uses "menu_EditPopup" while SeaMonkey uses "menu_Edit_Popup"
(Assignee)

Comment 1

8 years ago
Created attachment 406686 [details] [diff] [review]
Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

Includes attachment 405777 [details] [diff] [review] from Bug 516882 Comment 9. See also Bug 516882 Comment 7. If this is approved then we can remove the hack we added to SeaMonkey to hide the new message menu item. Later we can add more SeaMonkey specific adjustments to this file.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #406686 - Flags: review?(mschroeder)

Comment 2

8 years ago
(In reply to comment #0)
> http://mxr.mozilla.org/comm-central/source/calendar/lightning/content/messenger-overlay-sidebar.xul#125
> 
> Thunderbird uses "menu_EditPopup" while SeaMonkey uses "menu_Edit_Popup"

Wouldn't it be easier to just change SM to use "menu_EditPopup" rather than having a separate overlay?
(Assignee)

Comment 3

8 years ago
> Wouldn't it be easier to just change SM to use "menu_EditPopup" rather than
> having a separate overlay?

Unfortunate RC2 is out, or should be out by now.
(Assignee)

Comment 4

8 years ago
Might the SeaMonkey Council accept this change for 2.0.1?

Comment 5

8 years ago
I fear potentially breaking extensions between 2.0.x versions. This might have been easier if it had come up before freezing up that much and going into final RC.

Comment 6

8 years ago
(In reply to comment #5)
> I fear potentially breaking extensions between 2.0.x versions. This might have
> been easier if it had come up before freezing up that much and going into final
> RC.
Potentially it means extensions have to do less to make themselves compatible with both TB and SM as they can use the same overlay for both when it comes to the edit menu.

Comment 7

8 years ago
Ian, I fully understand that, but breaking any extensions in security/stability updates is a very bad idea.

Comment 8

8 years ago
(In reply to comment #7)
> Ian, I fully understand that, but breaking any extensions in security/stability
> updates is a very bad idea.
Do we know if any, other than Lightning, currently overlay the Edit menu?
I'd be expecting any change to an id to be in 2.1 rather than 2.0.x anyway, my quoting you previously probably implied 2.0.x though, sorry. I was replying to the more general reason why we'd want to change the id.

Comment 9

8 years ago
I'm perfectly happy with doing that id change in 2.1, it's 2.0.x what I was sensible to ;-)

Unfortunately, I don't think we have any reasonable possibility right now to find out who else might be using that ID :(
(Assignee)

Comment 10

8 years ago
1. Actually this ID is shared with Navigator via an overlay so there are three places where we have to change it.
2. This will actually make it easier for Firefox extensions to be ported to SeaMonkey as Thunderbird was just following the TB lead.
3. The rest of /suite/ actually uses menu_EditPopup.

I'd vote for this making 2.1. In the mean time we still want this fix in Lighting for SeaMonkey 2.0x

Comment 11

8 years ago
I wonder if would be a worthwhile endeavour to standardize a set of common (menuitem) ids across Mozilla-based applications to ease the work of extension authors...
Comment on attachment 406686 [details] [diff] [review]
Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

r=mschroeder. Looks good (from a Calendar Project pov), but maybe a SeaMonkey reviewer should also have a look at this patch. One nit: We have suite-overlay-messenger.xul and communicator-overlay-preferences.xul in lightning/content with this patch. You should decide which prefix SeaMonkey related files should use, suite or communicator.
Attachment #406686 - Flags: review?(mschroeder) → review+

Comment 13

8 years ago
I'd prefer to go for suite everywhere, communicator is a Netscape-ism only, IMHO.
(Assignee)

Comment 14

8 years ago
Comment on attachment 406686 [details] [diff] [review]
Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

> r=mschroeder. Looks good (from a Calendar Project pov), but maybe a SeaMonkey
> reviewer should also have a look at this patch.

Thanks! Asking for additional review from IanN
Attachment #406686 - Flags: review?(iann_bugzilla)

Comment 15

8 years ago
Comment on attachment 406686 [details] [diff] [review]
Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

r=me but only for comm-1.9.1, on comm-central we can, with suitable notification to extension developers, change the id for the edit menu on SeaMonkey.
Attachment #406686 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Comment 16

8 years ago
Comment on attachment 406686 [details] [diff] [review]
Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

http://hg.mozilla.org/releases/comm-1.9.1/rev/34a5ec85f7fc
Attachment #406686 - Attachment description: Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey → Patch v1.0 Add Edit->Calendar Properties menu item to SeaMonkey [comm-1.9.1 Checkin: Comment 16]

Updated

8 years ago
Keywords: checkin-needed

Comment 17

8 years ago
Will you use this bug or another for switching SM to use the same ID for the Edit menu as TB?
(Assignee)

Comment 18

8 years ago
> Will you use this bug or another for switching SM to use the same ID for the
> Edit menu as TB?

I'll file another bug under the SeaMonkey product since the flags there are more suitable.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Please file also a bug for renaming communicator-overlay-preferences.xul as discussed in comment#12 and comment#13.
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [comm-1.9.1 only]
Target Milestone: --- → 1.0
(Assignee)

Updated

8 years ago
Blocks: 526171
(Assignee)

Updated

8 years ago
Blocks: 526172
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.