Closed Bug 526601 Opened 10 years ago Closed 10 years ago

Places needs to use asyncClose instead of close on the database connection

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a3
Tracking Status
status1.9.2 --- unaffected

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 1 obsolete file)

It will throw after bug 469019 lands.
Attached patch v1.0 (obsolete) — Splinter Review
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #410577 - Flags: review?(mak77)
Whiteboard: [needs review mak]
Depends on: 496019
No longer depends on: 469019
Comment on attachment 410577 [details] [diff] [review]
v1.0

this patch is so complex that i'm scared...
Attachment #410577 - Flags: review?(mak77) → review+
Whiteboard: [needs review mak]
Whiteboard: [ready to land]
http://hg.mozilla.org/mozilla-central/rev/551abc8ab1aa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ready to land]
Comment on attachment 410577 [details] [diff] [review]
v1.0

We'll need this on 1.9.2 in order to fix bug 496019.
Attachment #410577 - Flags: approval1.9.2?
Backed out since I had to back bug 496019 out...
http://hg.mozilla.org/mozilla-central/rev/146dbbf6421b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #410577 - Flags: approval1.9.2?
Attached patch v1.1Splinter Review
Need to fix a test too...
Attachment #410577 - Attachment is obsolete: true
Attachment #411540 - Flags: review?(mak77)
Attachment #411540 - Flags: review?(mak77) → review+
I can't land bug 496019 without approval on this bug, or blocking+.
Flags: blocking1.9.2?
Blocks a blocker, is a blocker, a is a.
Flags: blocking1.9.2? → blocking1.9.2+
Whiteboard: [can land]
Blocks a non-blocking, isn't a blocker, a isn't a.
Flags: blocking1.9.2+ → blocking1.9.2-
http://hg.mozilla.org/mozilla-central/rev/e9f64cd044f3
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.3a1
Backed out...

http://hg.mozilla.org/mozilla-central/rev/f92a0d704ec3
http://hg.mozilla.org/mozilla-central/rev/8e986811ab38
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/7dc3608ec516
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: mozilla1.9.3a1 → mozilla1.9.3a3
OS: Mac OS X → All
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.