526760 - Port Bug 519357 - Only load known binary components from app directory - to comm-central.

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Bug 519357 just landed on trunk which completely broke running of comm-central apps - or at least the non-toolkit parts of them.

We need to port the patch.

Comment 1

[(not currently active) Ted Mielczarek]

Shouldn't have broken anything, according to bsmedberg. He says it should fail open in the absence of components.list.

Comment 2

[(not currently active) Ted Mielczarek]

All you should need are the rules.mk bits, and the packaging manifest change, FWIW.

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #1)
> Shouldn't have broken anything, according to bsmedberg. He says it should fail
> open in the absence of components.list.

Not quite true - components.list will exist in partial form (at least on debug + developer builds) from the mozilla-central part of the build. Hence none of the comm-central specific components will get loaded.

(In reply to comment #2)
> All you should need are the rules.mk bits, and the packaging manifest change,
> FWIW.

Yep, already ported, just waiting on my build to finish.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix

My build is still going (but looking promising), but I think this should work (I won't land before I've verified).

As bug 519357 should be landing on 1.9.2, then I'm not going to bother adding any branch ifdefs. If we want to set up builders before that happens, then we can add some (there are other issues I'm aware of with building 1.9.2 that will need ifdef changes anyway).

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/7560c2987dec

Comment 6

[Mark Banner (:standard8)]

That fixed it :-)