Package extensions components.list too

VERIFIED FIXED in seamonkey2.1a1

Status

SeaMonkey
Build Config
--
trivial
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.3})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.3
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 417967 [details] [diff] [review]
(Av1) Fix m-1.9.2+, Sort packaging lists
Attachment #417967 - Flags: review?(kairo)
(Assignee)

Comment 2

8 years ago
Created attachment 417969 [details] [diff] [review]
(Bv1-191) Support downgrading, Sort packaging lists
Attachment #417969 - Flags: approval-seamonkey2.0.2?

Comment 3

8 years ago
Comment on attachment 417967 [details] [diff] [review]
(Av1) Fix m-1.9.2+, Sort packaging lists

> bin/defaults/profile/bookmarks.html
>+bin/defaults/profile/chrome/*
> bin/defaults/profile/localstore.rdf
> bin/defaults/profile/mimeTypes.rdf
> bin/defaults/profile/panels.rdf
> bin/defaults/profile/search.rdf
>-bin/defaults/profile/chrome/*

Please don't mix the /* stuff in between of the lines, it makes analyzing the package-compare logs harder.


> [chatzilla]
>-bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/chatzilla-service.js
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome.manifest
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome/chatzilla.jar
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.js
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.rdf
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome.manifest
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/chatzilla.jar
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/icons/default/chatzilla-window.xpm
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/icons/default/chatzilla-window16.xpm
>-bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome.manifest
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/components.list
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/chatzilla-service.js
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/install.rdf
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome/chatzilla.jar
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome.manifest
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.js
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.rdf

r- for moving the langpack stuff around, please leave that at the end on the extensions lines.


>-[venkman]
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/components/venkman-service.js
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/chrome/venkman.jar
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/chrome.manifest
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/install.rdf
>+[debugqa]
>+bin/extensions/debugQA@mozilla.org/chrome.manifest
>+bin/extensions/debugQA@mozilla.org/chrome/debugqa.jar
>+bin/extensions/debugQA@mozilla.org/install.rdf

And please, leave stuff where it is if possible, those moves make reviews harder, and we'll replace the packages files with a common thing anyhow some time (hopefully soon).


And sorry, I couldn't spot the real changes in the diff anyhow, I can't review it that way.
Attachment #417967 - Flags: review?(kairo) → review-

Comment 4

8 years ago
Comment on attachment 417969 [details] [diff] [review]
(Bv1-191) Support downgrading, Sort packaging lists

No such large cosmetic changes on branch, please.
Attachment #417969 - Flags: approval-seamonkey2.0.2? → approval-seamonkey2.0.2-
(Assignee)

Comment 5

8 years ago
Created attachment 418038 [details] [diff] [review]
(Av2) Fix m-1.9.2+, Sort packaging lists
[Checkin: Comment 7]

Av1, with comment 3 suggestion(s).
Attachment #417967 - Attachment is obsolete: true
Attachment #418038 - Flags: review?(kairo)
(Assignee)

Comment 6

8 years ago
Created attachment 418039 [details] [diff] [review]
(Bv2-191) Support downgrading
[Checkin: Comment 8]

Bv1-191, with comment 4 suggestion(s).
Attachment #417969 - Attachment is obsolete: true
Attachment #418039 - Flags: approval-seamonkey2.0.2?
(Assignee)

Updated

8 years ago
Attachment #418038 - Attachment description: 535320-Av1_components.diff → (Av2) Fix m-1.9.2+, Sort packaging lists

Updated

8 years ago
Attachment #418038 - Flags: review?(kairo) → review+

Updated

8 years ago
Attachment #418039 - Flags: review+
Attachment #418039 - Flags: approval-seamonkey2.0.2?
Attachment #418039 - Flags: approval-seamonkey2.0.2+
(Assignee)

Comment 7

8 years ago
Comment on attachment 418038 [details] [diff] [review]
(Av2) Fix m-1.9.2+, Sort packaging lists
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/32011fda578c
Attachment #418038 - Attachment description: (Av2) Fix m-1.9.2+, Sort packaging lists → (Av2) Fix m-1.9.2+, Sort packaging lists [Checkin: Comment 7]
(Assignee)

Comment 8

8 years ago
Comment on attachment 418039 [details] [diff] [review]
(Bv2-191) Support downgrading
[Checkin: Comment 8]


http://hg.mozilla.org/releases/comm-1.9.1/rev/5926a1610381
Attachment #418039 - Attachment description: (Bv2-191) Support downgrading. → (Bv2-191) Support downgrading [Checkin: Comment 8]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: fixed-seamonkey2.0.2
Resolution: --- → FIXED
(Assignee)

Comment 9

8 years ago
V.Fixed, per tinderbox.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.