Last Comment Bug 535320 - Package extensions components.list too
: Package extensions components.list too
Status: VERIFIED FIXED
: fixed-seamonkey2.0.3
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1a1
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 526760
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-16 10:27 PST by Serge Gautherie (:sgautherie)
Modified: 2009-12-16 18:57 PST (History)
0 users
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Fix m-1.9.2+, Sort packaging lists (9.65 KB, patch)
2009-12-16 11:21 PST, Serge Gautherie (:sgautherie)
kairo: review-
Details | Diff | Splinter Review
(Bv1-191) Support downgrading, Sort packaging lists (9.38 KB, patch)
2009-12-16 11:22 PST, Serge Gautherie (:sgautherie)
kairo: approval‑seamonkey2.0.3-
Details | Diff | Splinter Review
(Av2) Fix m-1.9.2+, Sort packaging lists [Checkin: Comment 7] (4.75 KB, patch)
2009-12-16 16:18 PST, Serge Gautherie (:sgautherie)
kairo: review+
Details | Diff | Splinter Review
(Bv2-191) Support downgrading [Checkin: Comment 8] (1.00 KB, patch)
2009-12-16 16:19 PST, Serge Gautherie (:sgautherie)
kairo: review+
kairo: approval‑seamonkey2.0.3+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2009-12-16 10:27:33 PST

    
Comment 1 Serge Gautherie (:sgautherie) 2009-12-16 11:21:46 PST
Created attachment 417967 [details] [diff] [review]
(Av1) Fix m-1.9.2+, Sort packaging lists
Comment 2 Serge Gautherie (:sgautherie) 2009-12-16 11:22:31 PST
Created attachment 417969 [details] [diff] [review]
(Bv1-191) Support downgrading, Sort packaging lists
Comment 3 Robert Kaiser 2009-12-16 15:19:38 PST
Comment on attachment 417967 [details] [diff] [review]
(Av1) Fix m-1.9.2+, Sort packaging lists

> bin/defaults/profile/bookmarks.html
>+bin/defaults/profile/chrome/*
> bin/defaults/profile/localstore.rdf
> bin/defaults/profile/mimeTypes.rdf
> bin/defaults/profile/panels.rdf
> bin/defaults/profile/search.rdf
>-bin/defaults/profile/chrome/*

Please don't mix the /* stuff in between of the lines, it makes analyzing the package-compare logs harder.


> [chatzilla]
>-bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/chatzilla-service.js
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome.manifest
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome/chatzilla.jar
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.js
>+bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.rdf
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome.manifest
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/chatzilla.jar
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/icons/default/chatzilla-window.xpm
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome/icons/default/chatzilla-window16.xpm
>-bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/chrome.manifest
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/components.list
>+bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/components/chatzilla-service.js
> bin/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}/install.rdf
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome/chatzilla.jar
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/chrome.manifest
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.js
>-bin/extensions/langpack-@AB_CD@@chatzilla.mozilla.org/install.rdf

r- for moving the langpack stuff around, please leave that at the end on the extensions lines.


>-[venkman]
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/components/venkman-service.js
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/chrome/venkman.jar
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/chrome.manifest
>-bin/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}/install.rdf
>+[debugqa]
>+bin/extensions/debugQA@mozilla.org/chrome.manifest
>+bin/extensions/debugQA@mozilla.org/chrome/debugqa.jar
>+bin/extensions/debugQA@mozilla.org/install.rdf

And please, leave stuff where it is if possible, those moves make reviews harder, and we'll replace the packages files with a common thing anyhow some time (hopefully soon).


And sorry, I couldn't spot the real changes in the diff anyhow, I can't review it that way.
Comment 4 Robert Kaiser 2009-12-16 15:20:19 PST
Comment on attachment 417969 [details] [diff] [review]
(Bv1-191) Support downgrading, Sort packaging lists

No such large cosmetic changes on branch, please.
Comment 5 Serge Gautherie (:sgautherie) 2009-12-16 16:18:20 PST
Created attachment 418038 [details] [diff] [review]
(Av2) Fix m-1.9.2+, Sort packaging lists
[Checkin: Comment 7]

Av1, with comment 3 suggestion(s).
Comment 6 Serge Gautherie (:sgautherie) 2009-12-16 16:19:12 PST
Created attachment 418039 [details] [diff] [review]
(Bv2-191) Support downgrading
[Checkin: Comment 8]

Bv1-191, with comment 4 suggestion(s).
Comment 7 Serge Gautherie (:sgautherie) 2009-12-16 18:16:58 PST
Comment on attachment 418038 [details] [diff] [review]
(Av2) Fix m-1.9.2+, Sort packaging lists
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/32011fda578c
Comment 8 Serge Gautherie (:sgautherie) 2009-12-16 18:17:24 PST
Comment on attachment 418039 [details] [diff] [review]
(Bv2-191) Support downgrading
[Checkin: Comment 8]


http://hg.mozilla.org/releases/comm-1.9.1/rev/5926a1610381
Comment 9 Serge Gautherie (:sgautherie) 2009-12-16 18:57:42 PST
V.Fixed, per tinderbox.

Note You need to log in before you can comment on or make changes to this bug.