526777 - Livemark and Tagging services could better use XPCOMUtils

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

no reasons to not doing that, and also error-prone, see Bug 526709

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

So, this moves mostly of livemarkService and taggingService to XPCOMUtils.
I also removed Livemark Service dependencies from url-classifier helpers, that could be cool, but are really unneeded in this small context, indeed the code is practically same size without them, and i don't think is sane to depend on unofficial libraries from another component. If they are sane should be moved to an Util file.
Replaced getters with lazyGetters
cleaned up some const
removed some unused code

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 410570 [details] [diff] [review]
patch v1.0


> function LivemarkLoadListener(aLivemark) {
>   this._livemark = aLivemark;
>   this._processor = null;
>   this._isAborted = false;
>   this._ttl = gExpiration;
>+
>+  XPCOMUtils.defineLazyServiceGetter(this, "_bms",
>+                                     BMS_CONTRACTID,
>+                                     "nsINavBookmarksService");
>+  XPCOMUtils.defineLazyServiceGetter(this, "_ans",
>+                                     AS_CONTRACTID,
>+                                     "nsIAnnotationService");

also used by the service. any reason to not just make these lazy getters global in this file? that way there's 1 service getter *ever* in all of this code.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/84125ff8a317