526919 - Lightweight theme notification bar hides when loading new page

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Ryan Doherty (:rdoherty)]

STR:
Discovered in nightlies.

1) Add sm-personas01.mozilla.org to the add-ons whitelist
2) Visit http://sm-personas01.mozilla.org/en-US/external/mozilla/firstrun.php
3) Click on any persona thumbnail
4) Persona is applied, the notification bar pops up, but then immediately hides because a link was clicked.

Expected behaviour:
The notification bar stays visible for 5-10 seconds, then hides, regardless of user behavior.

Comment 1

[Johnathan Nightingale [:johnath]]

I agree that an instantly appearing-and-disappearing notification bar is not the desired effect. It's happening because we fire the install event and then immediately navigate off-page, which dismisses the notification bar.

I wouldn't want the notification bar to be on a straight 5-10s timer, because it's generally bad a11y practice to have UI on timers, but one possible solution could be to have a *minimum* time before auto-dismissal on navigation can happen. I don't know if we do that on any existing notification bars, would like to get Dao's sense of how ugly that would be.

A simpler option would just be to bump the persistence of the notification one notch, right?

The other way to approach this, of course, is just to change the behaviour of iframe/getpersonas so that:

- on hover: everything works as before
- on click: instead of apply-then-navigate, we just do navigate, but we navigate to something like http://www.getpersonas.com/en-US/persona/48888?autoInstall=true which then immediately fires the install event.

The net experience there would be similar for users - clicking does take them to the page and apply the persona, but now the notification bar is present to support undo. On the downside, it probably takes longer to actually apply, since we need to wait for another page load, and it also has us changing the web experience. It also feels a little... odd.

Comment 2

[Ryan Doherty (:rdoherty)]

I agree that 'fixing' this by changing the website would probably be faster/easier, but it is a roundabout method of avoiding this bug.

Comment 3

[Dão Gottwald [:dao]]

I think the password manager uses both persistence and a timer. We can do the same here.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

This allows one location change each for the pre- and post-install confirmation bars and makes sure the latter stays for at least 20 seconds.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/43a29d8d9a97

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/74645ed304c4