Closed Bug 526977 Opened 12 years ago Closed 12 years ago

Fonts are not readable if remote display to a machine with different endian

Categories

(Core :: Graphics, defect)

x86
OpenSolaris
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 562746

People

(Reporter: ginnchen+exoracle, Unassigned)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

This bug is reproducible with DISPLAY on Sun Ray client, XVR-600, XVR-1200.
xdpyinfo shows red, green, blue masks: 0xff, 0xff00, 0xff0000

It doesn't matter which machine Firefox is running on.
You can use "ssh -X" to start Firefox from another Solaris machine.
Attached image screenshot
Caused by Bug 515192
Blocks: 515192
git bisect shows the bad commit is

commit b5799e073e4e404aea277b7640eeee2120318823
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Jun 2 18:07:31 2009 +0100

    [xlib] Use bswap_32
    
    Byteswap the ARGB32 glyphs using bswap_32 instead of open-coding.


I think you should not use d++ in macro.
Attached patch patch for cairo (obsolete) — Splinter Review
Attached patch patch for cairoSplinter Review
Attachment #411388 - Attachment is obsolete: true
Attachment #411389 - Flags: review?(chris)
Actually, it happens if I remote display Firefox from SPARC to x86 machine, or from x86 to SPARC machine.
Nothing to do with xBGR.
Summary: Fonts are not readable on BGR framebuffer → Fonts are not readable if remote display to a machine with different endian
Comment on attachment 411389 [details] [diff] [review]
patch for cairo

Vladimir, can you help commit it to cairo?
The patch is obvious.
Attachment #411389 - Flags: review?(chris) → review?(vladimir)
Comment on attachment 411389 [details] [diff] [review]
patch for cairo

Redirecting to jeff
Attachment #411389 - Flags: review?(vladimir) → review?(jmuizelaar)
Comment on attachment 411389 [details] [diff] [review]
patch for cairo

Redirecting to Chris Wilson as he's the one that broke it.
Attachment #411389 - Flags: review?(jmuizelaar) → review?(chris)
Comment on attachment 411389 [details] [diff] [review]
patch for cairo

This is now on cairo HEAD, can we commit it to mozilla-central now?
Attachment #411389 - Flags: review?(chris) → review?(jmuizelaar)
Can this wait till the next cairo update? I'd rather not churn unless there's a good reason to.
ok, I can wait.
Depends on: 562746
Attachment #411389 - Flags: review?(jmuizelaar)
This was fixed in the last cairo merge.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Apparently it was unfixed.
Resolution: FIXED → DUPLICATE
Duplicate of bug: 562746
You need to log in before you can comment on or make changes to this bug.