Last Comment Bug 515192 - Update cairo to 655a4dbc36d95ce4a82cbc13aa9e2002b41fa4de
: Update cairo to 655a4dbc36d95ce4a82cbc13aa9e2002b41fa4de
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
: Milan Sreckovic [:milan]
Depends on: 515428 518172 526977
  Show dependency treegraph
Reported: 2009-09-08 10:38 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-12-07 10:34 PST (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Missing parentheses. (964 bytes, patch)
2009-09-10 09:40 PDT, Chris Wilson
no flags Details | Diff | Splinter Review

Description User image Jeff Muizelaar [:jrmuizel] 2009-09-08 10:38:58 PDT

Comment 1 User image Jeff Muizelaar [:jrmuizel] 2009-09-09 11:46:34 PDT
Backed out:
Comment 2 User image Jeff Muizelaar [:jrmuizel] 2009-09-09 11:48:01 PDT
This was causing problems like:

*** glibc detected ***
double free or corruption (!prev): 0x09b972b8 ***
======= Backtrace: =========
Comment 3 User image Jeff Muizelaar [:jrmuizel] 2009-09-09 14:41:47 PDT
Seems like this was also causing timeouts.
Comment 4 User image Chris Wilson 2009-09-10 09:40:28 PDT
Created attachment 399744 [details] [diff] [review]
Missing parentheses.
Comment 5 User image Jeff Muizelaar [:jrmuizel] 2009-09-10 16:45:15 PDT
(In reply to comment #4)
> Created an attachment (id=399744) [details]
> Missing parentheses.

That doesn't seem to sufficient to get things passing on the try server. I still get timeouts there. It also doesn't look like adding the parenthesis will help, because '>>' binds higher then '&' anyways.
Comment 6 User image Jeff Muizelaar [:jrmuizel] 2009-09-10 19:53:11 PDT
A try server run with c0e01d9cd71bd958e1b31a03cea4c08a1bdf4926 (Improve GC caching efficacy) reverted doesn't seem to have the problem. So it seems like that change is still the likely culprit.
Comment 7 User image Takuro Ashie 2009-09-15 22:41:44 PDT

It seems that it lacks cair-qt.h and cairo-qt-surface.cpp, which is newly added into the cairo (probably renamed from cairo-qpainter.h and cairo-qpainter-surface.cpp). It's needed by Qt build.
Comment 8 User image Joe Drew (not getting mail) 2010-02-08 14:59:27 PST
What happened to this bug? Is it subsumed by bug 542605?

Note You need to log in before you can comment on or make changes to this bug.