515192 - Update cairo to 655a4dbc36d95ce4a82cbc13aa9e2002b41fa4de

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Backed out:

http://hg.mozilla.org/mozilla-central/rev/a52ca6a09ae7

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This was causing problems like:

*** glibc detected ***
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/firefox-bin:
double free or corruption (!prev): 0x09b972b8 ***
======= Backtrace: =========
/lib/libc.so.6[0xdeaf5d]
/lib/libc.so.6(cfree+0x90)[0xdee5b0]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libxpcom_core.so(free+0x41)[0x6a7990]
/usr/lib/libX11.so.6(XFreeGC+0xaf)[0xaa8adf]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libthebes.so[0x14e79a6]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libthebes.so[0x14e7ac4]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libthebes.so[0x14e8a11]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libthebes.so[0x14e8bf7]
/usr/lib/libX11.so.6(XCloseDisplay+0xad)[0xaa0aad]
/usr/lib/libgdk-x11-2.0.so.0[0x3f9924]
/lib/libgobject-2.0.so.0(g_object_unref+0x16c)[0x4cb17c]
/usr/lib/libgdk-x11-2.0.so.0(gdk_display_close+0xa6)[0x3d8516]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libxul.so[0xd34329]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/libxul.so(XRE_main+0x34c7)[0xd3cda4]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/firefox-bin[0x8048e72]
/lib/libc.so.6(__libc_start_main+0xdc)[0xd9adec]
/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/bin/firefox-bin[0x8048a21]

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Seems like this was also causing timeouts.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252513029.1252525885.25430.gz

Comment 4

[Chris Wilson]

Attachment: Missing parentheses.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #4)
> Created an attachment (id=399744) [details]
> Missing parentheses.

That doesn't seem to sufficient to get things passing on the try server. I still get timeouts there. It also doesn't look like adding the parenthesis will help, because '>>' binds higher then '&' anyways.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

A try server run with c0e01d9cd71bd958e1b31a03cea4c08a1bdf4926 (Improve GC caching efficacy) reverted doesn't seem to have the problem. So it seems like that change is still the likely culprit.

Comment 7

[Takuro Ashie [:ashie]]

http://hg.mozilla.org/mozilla-central/rev/7a9262f6dbc0

It seems that it lacks cair-qt.h and cairo-qt-surface.cpp, which is newly added into the cairo (probably renamed from cairo-qpainter.h and cairo-qpainter-surface.cpp). It's needed by Qt build.

Comment 8

[Joe Drew (not getting mail)]

What happened to this bug? Is it subsumed by bug 542605?