526995 - [Autoconfig] msgWindow is undefined

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Giuseppe Tino]

Those are the steps:
1)Create a new account
2)In mail account setup window I put: My name, CORRECT email address (@Gmail.com), CORRECT password, remember password YES, Continue
 	R-> Shredder has found the settings for your email account
		Username:My email address
		Incoming: imap.googlemail.com	IMAP	993	SSL/TLS
		Outgoing: smtp.googlemail.com	SMTP	465	SSL/TLS
3)I click on "Create account"
	R-> Error Creating Account
		TypeError: msgWindow is undefined
4)I click on "ok"
	R-> A red string appear near the password field: "Username or password invalid"
5)I click on "start over"
6)I retype all the data like in step 2 and click on "continue"
	R-> The same response of step 2
7)I click on "Create Account"
	R-> Error Creating account: Incoming server already exist
8)I click on "Ok"
9)I click on "Cancel"

NOTE 1: In the left sidebar of TB, there's no the new account, (all folders visualization)
NOTE 2: If i go in the C:\<TB PROFILE FOLDER>\ImapMail now there is a new folder called imap.googlemail.com.sbd

Comment 1

[Blake Winton (:bwinton) (:☕️)]

I've tried these steps with my gmail address and a version of TB3 that I built myself just now, and I can't reproduce it.

Which version of TB3 were you using?  (We might have fixed it since beta 4.  If you were using beta 4, would you mind re-trying it with a nightly build?)

Are you able to record a screencast, which might show me what you're doing differently to trigger this bug?

Thanks,
Blake.

Comment 2

[Giuseppe Tino]

Attachment: bug's "screencast"

Comment 3

[Giuseppe Tino]

Attachment: bug's "screencast"

Comment 4

[Giuseppe Tino]

Sorry for the triple post, I had problems to send the attachment.
I'm using the latest build but I had the same problem with tb3 beta 4.
I'm unable to record a screencast, I hope that this ppt will be sufficient

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Attachment: Check that we have a msgWindow earlier, and pass one in from the "Create a new account" button. Also log exceptions.

So, we had this AddMailAccount function just sitting there which did this:
function AddMailAccount()
{
  let msgWindow = Components.classes["@mozilla.org/messenger/services/session;1"]
                            .getService(Components.interfaces.nsIMsgMailSession)
                            .topmostMsgWindow;
  NewMailAccount(msgWindow);
}

which really looks like the right thing, so I'm just going to use that one instead of msgNewMailAccount().

Thanks,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

It's got a patch, and it's a really annoying bug, so I'm asking for blocking-tb3.

Comment 7

[Phil Ringnalda (:philor)]

Yeah, "two out of the three ways you can create an account actually work" isn't going to fly.

Comment 8

[David :Bienvenu]

Comment on attachment 410922 [details] [diff] [review]
Check that we have a msgWindow earlier, and pass one in from the "Create a new account" button.  Also log exceptions.

I tried all three cases (new profile, file | add mail account, and add mail account from account settings), and all three worked. So, r/sr=me, assuming it all works for philor as well.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 410922 [details] [diff] [review]
Check that we have a msgWindow earlier, and pass one in from the "Create a new account" button.  Also log exceptions.

Had to back three quarters of it out to get to where I could see the logging happen, but then it's mighty pretty. Ship it!

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Shipped as
http://hg.mozilla.org/releases/comm-1.9.1/rev/59563798bc33
http://hg.mozilla.org/comm-central/rev/4ac6e14fd68b

Thanks,
Blake.