527489 - calls to bz_alter_column on FK referenced columns will lose their referenced status in bz_schema unless the REFERENCES hash is included

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Greg Hendricks]

This affects bugzilla 3.2+

Any calls to bz_alter_schema will overwrite the references section if they are not explicitly included in the call.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Does this fix things, ghendricks?

Comment 2

[Greg Hendricks]

Comment on attachment 411471 [details] [diff] [review]
v1

>+        # Preserve foreign key definitions in the Schema object when altering
>+        # types.
>+        if (defined $current_def->{REFERENCES}) {
>+            # Make sure we don't modify the caller's $new_def.
>+            $new_def = dclone($new_def);
>+            $new_def->{REFERENCES} = $current_def->{REFERENCES};
>+        }

One question. How do we alter a foreign key? For example if we need to change from CASCADE delete to something else? Should there be a separate bz_alter_fk? Or do we just want to drop and recreate?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> One question. How do we alter a foreign key? For example if we need to change
> from CASCADE delete to something else? Should there be a separate bz_alter_fk?
> Or do we just want to drop and recreate?

  You just drop and re-create, for now.

Comment 4

[Max Kanat-Alexander]

ghendricks: Did you test this patch against the problem you were having?

Comment 5

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.131; previous revision: 1.130
done