527615 - nsIWidget::MakeFullScreen() fails when called before Show()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Karl Tomlinson (:karlt)]

The problem is that only the GdkWindow and not the GtkWindow is made
fullscreen.  When the GtkWindow is shown it does not know that it should be
fullscreen and unfullscreens the GdkWindow.

(This used to work sometimes before the fix for bug 509278 when Show() was
called twice because the second call would again fullscreen the GdkWindow.
Since bug 509278, the second call to Show with the same state does nothing.)

Comment 1

[Karl Tomlinson (:karlt)]

Fennec wants this for starting in fullscreen mode.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: use gtk (instead of gdk) funcs

There was also an unnecessary gdk_window_resize(mGdkWindow, aWidth, aHeight) in only one of the NativeResize methods.

Comment 3

[Karl Tomlinson (:karlt)]

This was probably meant to be tested by http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/chrome/test_fullscreen.xul
but that might get a fullscreen event but not the unfullscreen.
With bug 517379, I don't know how it even got the fullscreen event.

A test might wait for focus and then check the fullScreen property.
I think we'll need bug 517379 fixed to pick up the unfullscreen notification.

Comment 4

[Joe Drew (not getting mail)]

This is a pretty simple fix, and quite important to have on mobile. -> should block

Comment 5

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/115ee72e7308

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 411352 [details] [diff] [review]
use gtk (instead of gdk) funcs

This patch fixes the fullscreen _and_ tearing-while-scrolling problems we had experienced on N900/N810

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Surprised to see that this doesn't have a blocking-fennec flag set ...

Comment 9

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fe9d253b1040

Comment 10

[Karl Tomlinson (:karlt)]

(In reply to comment #3)
> A test might wait for focus and then check the fullScreen property.
> I think we'll need bug 517379 fixed to pick up the unfullscreen notification.

Bug 517379 wasn't quite what I thought.  Bug 512529 is probably what is needed.

Comment 11

[Doug Turner (:dougt)]

Not sure why that code was removed.  I thought we had to call MakeFullScreen() on Show() because of persistent window properties.  Maybe gtk does more than gdk does.