Closed Bug 527836 Opened 15 years ago Closed 15 years ago

imap not setting public namespace from prefs correctly

Categories

(MailNews Core :: Networking: IMAP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

(Blocks 2 open bugs)

Details

(Keywords: fixed-seamonkey2.0.1)

Attachments

(1 file)

Attached patch proposed fixSplinter Review
During the big string cleanup/frozen linkages patch, I think we messed up the setting of the public namespace from prefs. Since most users get the namespaces from the server, this isn't a huge issue, but it screws up fakeserver, and the tests that use it, and probably other servers that don't support namespaces. patch upcoming.

If you go look at the 1.8 code, you'll see that the conversion was messed up.

http://mxr.mozilla.org/mozilla1.8/source/mailnews/imap/src/nsImapIncomingServer.cpp#182
Attachment #411588 - Flags: superreview?(bugzilla)
Attachment #411588 - Flags: review?(bugmail)
Attachment #411588 - Flags: review?(bugmail) → review+
I suspect not fixing this bug will break 3.0 users who try to override the public namespace using prefs. I doubt that it will affect very many users, but I believe it's a fairly safe fix for 3.0
Attachment #411588 - Flags: superreview?(bugzilla)
Attachment #411588 - Flags: superreview+
Attachment #411588 - Flags: approval-thunderbird3+
I pushed this to get it in for today's nightlies:

http://hg.mozilla.org/comm-central/rev/97b7ef46f894
http://hg.mozilla.org/releases/comm-1.9.1/rev/5c33b2b9a8c4
Status: NEW → RESOLVED
Closed: 15 years ago
OS: Windows NT → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: