imap not setting public namespace from prefs correctly

RESOLVED FIXED in Thunderbird 3.0rc1

Status

MailNews Core
Networking: IMAP
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

(Blocks: 2 bugs, {fixed-seamonkey2.0.1})

Trunk
Thunderbird 3.0rc1
fixed-seamonkey2.0.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 411588 [details] [diff] [review]
proposed fix

During the big string cleanup/frozen linkages patch, I think we messed up the setting of the public namespace from prefs. Since most users get the namespaces from the server, this isn't a huge issue, but it screws up fakeserver, and the tests that use it, and probably other servers that don't support namespaces. patch upcoming.

If you go look at the 1.8 code, you'll see that the conversion was messed up.

http://mxr.mozilla.org/mozilla1.8/source/mailnews/imap/src/nsImapIncomingServer.cpp#182
Attachment #411588 - Flags: superreview?(bugzilla)
Attachment #411588 - Flags: review?(bugmail)
Attachment #411588 - Flags: review?(bugmail) → review+
(Assignee)

Comment 1

8 years ago
I suspect not fixing this bug will break 3.0 users who try to override the public namespace using prefs. I doubt that it will affect very many users, but I believe it's a fairly safe fix for 3.0
Attachment #411588 - Flags: superreview?(bugzilla)
Attachment #411588 - Flags: superreview+
Attachment #411588 - Flags: approval-thunderbird3+
I pushed this to get it in for today's nightlies:

http://hg.mozilla.org/comm-central/rev/97b7ef46f894
http://hg.mozilla.org/releases/comm-1.9.1/rev/5c33b2b9a8c4
Status: NEW → RESOLVED
Last Resolved: 8 years ago
OS: Windows NT → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1

Updated

8 years ago
Keywords: fixed-seamonkey2.0.1
Blocks: 539572
Blocks: 160644
You need to log in before you can comment on or make changes to this bug.