527845 - App update can't deal with read-only files

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Justin Dolske [:Dolske]]

Trying to update from 3.6a2 to 3.6b2 on my Tegra fails (with a complete .mar) because 2 files in the appdir were marked read-only (and hidden, in case that matters).

The update log shows:

EXECUTE ADD \Program Files\Firefox\browserconfig.properties
remove failed: -1,0 (\Program Files\Firefox\browserconfig.properties)
### execution failed

(browserconfig.properties is the readonly file)

Comment 1

[Justin Dolske [:Dolske]]

[The reason this file is read-only appears to be due to a partner mistake, they had also modified the contents to change the homepage.]

Comment 2

[Robert Strong (they/them - no direct email)]

Can you attach the full update log for reference? Thanks

I believe there is a supported method for changing the home page using the distribution mechanism implemented by Thunder

Comment 3

[Justin Dolske [:Dolske]]

The code does try to ensure writability, but...

updater_wince.cpp

53 int _wchmod(const WCHAR* path, unsigned int mode) 
54 {
55   return 0;
56 }

Doh.

Comment 4

[Robert Strong (they/them - no direct email)]

That was added in bug 458950.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - use SetFileAttributes to emulate _wchmod

Not sure if we want to try to respect the file attributes or just set them to FILE_ATTRIBUTE_NORMAL.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 411603 [details] [diff] [review]
patch rev1 - use SetFileAttributes to emulate _wchmod

Should be fine; I don't think there are any other interesting attributes that we care to preserve on CE.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: updated patch for checkin

Changed SetFileAttributes to SetFileAttributesW. I'll land as soon as the tree is green as long as it isn't too late in the evening

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/761988dd0d81

Comment 9

[Robert Strong (they/them - no direct email)]

Filed bug 527890 for WinCE / WinMo xpcshell tests for this bug. Minusing in-testsuite since bug 527890 will cover the tests for this bug.

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 411606 [details] [diff] [review]
updated patch for checkin

Requesting 1.9.2 a little preemptively since I'll verify this on the board tomorrow at work.

Comment 11

[Robert Strong (they/them - no direct email)]

dolske verified this did the trick with a partial trunk nightly as well.

Pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2227ed93dfe6