Closed
Bug 527859
Opened 15 years ago
Closed 15 years ago
Add search form to top and bottom of results
Categories
(support.mozilla.org :: Search, defect, P1)
support.mozilla.org
Search
Tracking
(Not tracked)
VERIFIED
FIXED
1.5
People
(Reporter: jsocol, Assigned: jsocol)
References
()
Details
(Whiteboard: sumo_only)
Attachments
(1 file)
2.05 KB,
patch
|
paulc
:
review+
|
Details | Diff | Splinter Review |
We've talked about this but there's no bug for it, so here we go:
A search form at the top and bottom of the results. The actual query should be pre-filled with the current search term.
This should be fairly thin, we don't want to take too much space from the results. But using the sidebar search box is unintuitive and doesn't match user experience on other sites.
Assignee | ||
Updated•15 years ago
|
Component: Knowledge Base Software → Search
Assignee | ||
Updated•15 years ago
|
Whiteboard: [good first bug]
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → james
Priority: -- → P1
Whiteboard: [good first bug]
Assignee | ||
Comment 1•15 years ago
|
||
Since there are only 10 results/page, and we don't have a setting to change that, I'm wondering if the top and bottom locations are both necessary--especially since the bottom already has the "Ask a New Question" call-to-action.
I'm going to do it with just the refine form at the top, and we'll see how it looks. If that's no good, we can add it to the bottom as well.
Comment 2•15 years ago
|
||
+1 from me.
Assignee | ||
Comment 3•15 years ago
|
||
This implements the form at the top (comment 1). I also touched up some CSS in the area to compress some empty space.
Attachment #413384 -
Flags: review?(paulc)
Comment 4•15 years ago
|
||
Comment on attachment 413384 [details] [diff] [review]
add the form, tweak some CSS
Looks good. With escaped values and everything :)
Attachment #413384 -
Flags: review?(paulc) → review+
Assignee | ||
Comment 5•15 years ago
|
||
r56506.
Unblocking bug 501880 : to maintain the advanced search options when using this form to refine the search, you might need to conditionally add more hidden inputs.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
Verified FIXED using https://sumo-forumux.stage.mozilla.com/search.php?where=f&locale=en-US&q=paris+hilton+is+ugly&sa= :-)
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Flags: in-litmus?
Assignee | ||
Updated•15 years ago
|
Whiteboard: sumo_only
Comment 7•15 years ago
|
||
I wrote a Litmus testcase for this under
https://litmus.mozilla.org/show_test.cgi?id=9838
in-litmus+
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•