Closed
Bug 527888
Opened 16 years ago
Closed 16 years ago
[faceted search] Make results page a little less painfully wrong in rtl
Categories
(Thunderbird :: Search, defect)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: philor, Assigned: philor)
Details
(Whiteboard: [has l10n impact])
Attachments
(3 files)
|
1.18 KB,
patch
|
standard8
:
review+
ehsan.akhgari
:
ui-review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
|
157.79 KB,
image/png
|
Details | |
|
163.49 KB,
image/png
|
Details |
Screenshot - before
Touching things using global.dtd made me realize that while glodaFacetView.xhtml includes it, it doesn't actually use it in the usual way of in-product HTML files, <body dir="&locale.dir;">. Looking at the state without it, where we have checkboxes like "[ ] 1) word)" and when we have more than one page of results they're described as the equivalent of "10 59 of", I think we probably do want to use it :)
Screenshots to follow.
Attachment #411635 -
Flags: ui-review?(ehsan)
Attachment #411635 -
Flags: review?(bugzilla)
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Flags: blocking-thunderbird3?
Whiteboard: [has l10n impact]
|
||
Comment 3•16 years ago
|
||
Comment on attachment 411635 [details] [diff] [review]
Fix
Yes, that seems a lot better. I think we should take this for rc1 even if it isn't perfect - especially as it appears to be way better than what we have at the moment.
Attachment #411635 -
Flags: review?(bugzilla)
Attachment #411635 -
Flags: review+
Attachment #411635 -
Flags: approval-thunderbird3+
|
||
Updated•16 years ago
|
Attachment #411635 -
Flags: ui-review?(ehsan) → ui-review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 411635 [details] [diff] [review]
Fix
The after screenshot is what should happen for RTL builds, so ui-r=me for correct RTL behavior.
There is another problem, however, which is caused by the fact that the message subject and text can itself be LTR, and is treated as RTL with this change, but this is a more general problem throughout the Mozilla codebase and the same thing would happen if you have RTL messages in LTR builds, so I guess this is not an issue that we might want to fix in this bug.
|
||
Updated•16 years ago
|
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Whiteboard: [has l10n impact] → [has l10n impact][has reviewed patch; needs landing]
Target Milestone: --- → Thunderbird 3.0rc1
|
|
Assignee | |
Comment 5•16 years ago
|
||
http://hg.mozilla.org/comm-central/rev/62899d00a002
http://hg.mozilla.org/releases/comm-1.9.1/rev/c5e52ffc5447
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [has l10n impact][has reviewed patch; needs landing] → [has l10n impact]
You need to log in
before you can comment on or make changes to this bug.
Description
•