527971 - Experimental add-ons can be installed without checking checkbox

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

1) Log out of AMO.
2) Go to a page with experimental add-ons (https://addons.mozilla.org/en-US/firefox/addon/45725)
3) Click on the Add to Firefox button without clicking on the 'Allow me' checkbox.

The install dialog appears, when it shouldn't.

Comment 1

[Justin Scott [:fligtar]]

Yeah... we need to fix this ASAP

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: v1

Fix.

Comment 3

[Ryan Doherty (:rdoherty)]

Attachment: v2

v2 with less changes.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 411832 [details] [diff] [review]
v2

Yes, ship it.

Comment 5

[Fred Wenzel [:wenzel]]

Does it work in Safari 3?

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> Does it work in Safari 3?

It didn't work for me in Opera 7 either. plsfix

Comment 7

[Ryan Doherty (:rdoherty)]

r55960

http://www.youtube.com/watch?v=BzbOoJNC_TU

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/9331 and https://preview.addons.mozilla.org/en-US/firefox/search?q=stephend&cat=all&advancedsearch=1&as=1&appid=1&lver=any&atype=0&pp=20&pid=0&sort=&lup=.

Comment 10

[Pratibha]

Search unreviewed add-ons button states are changed with zamboni and there is no "allow me" options seen anymore. SO moving in-litmus: and in-testuite: to "-"

There is a test case for verifying unreviewed add-on:
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9435 - Button_states:Verify add-on button status for a Not Reviewed add-on for anonymous users