52822 - Browser fails to launch editor when using Classic Skin

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P1)

Description

[kinmoz]

In my 09/15/00 8am Win32 Debug build, I can't launch the editor from the 
editor icon at the bottom of the browser window when using the Classic Skin. I 
can if I switch themes to the Modern Skin.

Comment 1

[kinmoz]

I should add that I can launch the Editor if I select File->"New Blank Page to 
Edit" from the menus.

The editor button on the mailnews window seems to be broken too.

Comment 2

[Doron Rosenberg (IBM)]

52808 may be related, freeze on exit of composer (perhaps the same checkins)

Comment 3

[Doron Rosenberg (IBM)]

win32 2000091505, I can launch composer using classic.

Comment 4

[Charles Manske]

Debug build 2000091312 on Windows: I can launch Composer from Navigator button.

Comment 5

[Asa Dotzler [:asa]]

I do not see this in 091508 mozilla win32 build on NT4.  Editor launches fine here.

Comment 6

[kinmoz]

shanjian also reported seeing this today problem.

Comment 7

[Doron Rosenberg (IBM)]

punting to themes, as this seems to be Classic related.  Perhaps a commercial
only bug?

Comment 8

[hangas]

Marking nsbeta3+ and P2.  Sending to Joe.  We need composer to work.  I am not 
sure that this is really a problem in the Classic Theme but let's start there and 
see where we get...

Comment 9

[hangas]

*** Bug 53119 has been marked as a duplicate of this bug. ***

Comment 10

[hangas]

This bug has now been reported on Windows and Mac.  Probably an issue with Linux 
as well if this is in the skin.

Comment 11

[Tracy Walker [:tracy]]

this worked fine on windows commercial classic skin build 2000-09-20-09-M18
and mac commercial classic skin build 2000-09-20-04-M18

Comment 12

[Kathleen :Brade]

At a glance, EditModeTabs.css is not in my dist folder on Mac so that is a 
problem.  Why is that file in a "win" directory? Why does Unix export it? Why is 
it @include'd?  Why doesn't any other skin use this file?

Comment 13

[Phil Peterson]

PDT thinks that if this really happens as reported, it's a P1. If it doesn't,
let's resummarize or close the bug.

Comment 14

[Joe Hewitt (gone)]

EditModeTabs.css is used exclusively for windows classic (aka unix classic) to 
give a slightly different look to the tabs in the edit mode toolbar in 
composer.  That's why it's in a windows only directory.  

This file is currently not making it into classic.jar under windows because 
themes/classic/editor/win has it's own jar.mn which isn't being found because 
themes/classic/makefile.win doesn't point there anymore since the jar changes.  
Fix in hand, will land later today.

Comment 15

[Joe Hewitt (gone)]

I should note that I will also add a dummy EditModeTabs.css for Mac.  This is a 
consequence of having mac and windows classic sharing the same folder but not 
all of the same styles.

Comment 16

[Joe Hewitt (gone)]

This still works for me.  Can someone verify if it works for them as well?

Comment 17

[rubydoo123]

works for me too on win98 using the 2000092005 build. changing themes on the fly
still wipes everything away in the browser window, mail window and composer.

Comment 18

[Joe Hewitt (gone)]

Fixed.

Comment 19

[Kathleen :Brade]

interesting...
hewitt comments:  "I should note that I will also add a dummy EditModeTabs.css 
for Mac.  This is a consequence of having mac and windows classic sharing the 
same folder but not all of the same styles."

EditModeTabs.css seem to be identical...

Is there some reason we are duplicating files in the source tree (which will lead 
to many, many problems) rather than using the same file?

verifying; the editor can now be launched when using the classic skin

Comment 20

[Patty Mac]

verified ok on platforms (2000-11-27-08-mtrunk)