Closed Bug 528690 Opened 15 years ago Closed 15 years ago

Shouldn't be possible to move message to virtual folder

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(thunderbird3.0 .1-fixed)

Status:
VERIFIED FIXED
Milestone:
Thunderbird 3
Tracking Flags:
Tracking Status
thunderbird3.0 --- .1-fixed

People

(Reporter: omnisilver, Assigned: Bienvenu)

References

Details

(Keywords: dataloss, Whiteboard: [tb3ride-along][fixed RC1 build 2])

Attachments

(1 file)

proposed fix
1.96 KB, patch
philor
: review+
standard8
: superreview+
standard8
: approval-thunderbird3+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0 In submenus, i can move a message to a virtual folder. Then, the message is lost because he is not visible in the virtual folder. Reproducible: Always Steps to Reproduce: 1.Select a message 2.In submenus, Move to → a vitual folder 3.Constat that the message is lost Actual Results: Message move to vitual folder. Expected Results: It should'nt be possible to move or copy a message to a virtual folder. I discover this bug via Litmus, to test RC1.
Version: unspecified → 3.0
Blocks: qa-tb3.0rc1
Whiteboard: dupeme
xref 350868
Component: General → Folder and Message Lists
QA Contact: general → folders-message-lists
I can reproduce this on the RC build. This is effectively dataloss as we're allowing an incorrect move (interestingly undo seems to work, but only if you realise in time, of course).
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-thunderbird3?
Keywords: dataloss
Whiteboard: dupeme
Severity: normal → critical
Not going to block on this but we'll take a patch if there is a respin (which is likely).
Flags: blocking-thunderbird3? → blocking-thunderbird3-
Whiteboard: [tb3ride-along]
As a side note, I notice that I can also attempt to move/copy messages to top-level account folders which doesn't seem right either.
folderwidgets.xml, which creates the file menu, only calls the filter function on the top level menu items, which are servers. And the icing on the cake is that we return true for canFile on servers.
Attached patch proposed fix — — Splinter Review
we need to clone the mode for sub-menus so filters will work. There's a possibility this might fix the mac issue of no sub-menus as well...I'll check that out.
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED
Attachment #412675 - Flags: superreview?(bugzilla)
Attachment #412675 - Flags: review?(philringnalda)
Summary: Should't be possible to move message to vitual folder → Shouldn't be possible to move message to virtual folder
Comment on attachment 412675 [details] [diff] [review] proposed fix r=me other than whatever happened to cause that whitespace before the <![CDATA[ - at least, I'm assuming that isn't somehow a part of the fix.
Attachment #412675 - Flags: review?(philringnalda) → review+
Attachment #412675 - Flags: superreview?(bugzilla)
Attachment #412675 - Flags: superreview+
Attachment #412675 - Flags: approval-thunderbird3+
fixed for rc1 and trunk
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
Checked into relbranch for build 2 of RC 1: http://hg.mozilla.org/releases/comm-1.9.1/rev/5fa7e7fec8c0
Whiteboard: [tb3ride-along] → [tb3ride-along][fixed RC1 build 2]
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3
Status: RESOLVED → VERIFIED
Whiteboard: [tb3ride-along][fixed RC1 build 2] → [tb3ride-along][fixed RC1 build 2][fixedtb301]
status-thunderbird3.0: --- → .1-fixed
Whiteboard: [tb3ride-along][fixed RC1 build 2][fixedtb301] → [tb3ride-along][fixed RC1 build 2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: