528769 - Toolbar GTK+ buttons do not visually depress when clicked

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Devin Cofer]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2b2) Gecko/20091110 Firefox/3.6b2
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2b2) Gecko/20091110 Firefox/3.6b2

On GNU/Linux, using GTK+ 2.18.3 (which Firefox was built with) and system Cairo (not sure if this has an impact), the toolbar buttons (Back, Reload, Home, Close Tab, New Tab, etc.) do not visually depress when clicked. Multiple GTK+ themes were tried.

Reproducible: Always

Steps to Reproduce:
1. Click toolbar button (Back, Reload, Home, Close Tab, New Tab, etc.) and hold down the mouse button.
Actual Results:  
The GTK+ button is not depressed.  The actual function of the button works once you release the mouse, as expected, but there is no visual of the button being depressed, as is the norm in most GTK+ themes.

Expected Results:  
The button is visually depressed, if that is what the GTK+ theme is set to.

This glitch appeared in either Firefox 3.6b2 or 3.6b1, more likely the former.  Firefox 3.5.5 demonstrates no problems at all.  Multiple GTK+ themes were tried, all with the same effect.

GTK+ version is 2.18.3.  However, again, Firefox 3.5.5 works fine with that same GTK+ version.

System Cairo was used.  Not sure if this has an impact.

Comment 1

[Devin Cofer]

This problem appears to also be present in 3.7a1pre as of this revision: http://hg.mozilla.org/mozilla-central/rev/d7c52410fa6a

Comment 3

[Mathieu Pellerin]

Any chance we can get some activity on this bug before firefox 3.6 final is released?

Firstly, could a linux user confirm the bug (it takes a second)?

Comment 4

[Michael Ventnor]

I can definitely confirm this. We now need to know the most recent build which does not show this bug, but I don't have the time to do so.

Comment 5

[Michael Ventnor]

I don't use system Cairo, so that's not the problem.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

cc'ing dao, who's made a few theme changes in the past few months

Is this happening on 64 bit builds of Firefox, or all builds?

Comment 7

[Hussam Al-Tayeb]

I use a 32bit build and can see the bug. It's not just 64bit builds.

Comment 8

[Dão Gottwald [:dao]]

This belongs in Core/Widget: Gtk. People aware of this should always correct it, so that the right people get the bugmail.

This was caused by bug 496770.

Comment 9

[Karl Tomlinson (:karlt)]

blocking-firefox3.6+ -> blocking1.9.2?

Comment 10

[Karl Tomlinson (:karlt)]

Same issue on GTK+2.16.6.

Comment 11

[Karl Tomlinson (:karlt)]

Attachment: revert predicate for drawing "button"

Thanks Dão for identifying the patch that caused the regression.
This reverts the problem part of the changes made in bug 496770.

It seems that (Moz)GtkWidgetState::depressed is different from GtkButton::depressed.  Maybe there's some more precise test to use here, but I'm not familiar with (Moz)GtkWidgetState so it seems safest to just revert the change.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 414762 [details] [diff] [review]
revert predicate for drawing "button"

stealing review

Comment 13

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/2e54a2202a53

Comment 14

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/58d4bf2d8361