528796 - nsIBoxObject::GetScreenX/Y returns device pixels, not css pixels

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Brooks [:db48x]]

That could be by design, but I doubt it since ::GetX/Y/Width/Height all return CSS pixels.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: bug528796-1.diff

Comment 2

[Daniel Brooks [:db48x]]

I haven't checked for tests yet, but it's time for my nap

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm ... I don't think we should change this, actually. This interface is deprecated anyway, it doesn't seem worth the risk.

Comment 4

[Daniel Brooks [:db48x]]

mmm, this fixes the tab drag and drop bug that causes dropped tabs to be inserted into the wrong place in the tab strip.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 412464 [details] [diff] [review]
bug528796-1.diff

hmm OK!

Comment 6

[Daniel Brooks [:db48x]]

it does break one test, according to the tryserver: test_popup_scaled.xul

Comment 7

[Daniel Brooks [:db48x]]

Attachment: bug528796-2.diff

fixes the test

Comment 8

[Daniel Brooks [:db48x]]

Thanks roc. fixed.

Comment 9

[Wladimir Palant]

For reference, that's what landed:

http://hg.mozilla.org/mozilla-central/rev/0ccbfef948d5
http://hg.mozilla.org/mozilla-central/rev/dd8c6449abd4
http://hg.mozilla.org/mozilla-central/rev/1a0b0ec63c7a