528872 - Attachments in attachments table should have CSS classes to help with styling

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

To make styling easier, patches in the attachments table should have the 'bz_patch' class.

Comment 1

[Reed Loden [:reed]]

Actually, justdave and timeless had a good idea to add some more CSS styles. New patch coming.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v2

Untested.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 412545 [details] [diff] [review]
patch - v2

it's live on bugzilla-stage-tip, and will be in production sometime soon.

Comment 4

[Frédéric Buclin]

Comment on attachment 412545 [details] [diff] [review]
patch - v2

>+      <tr class="[% "bz_contenttype_" _ attachment.contenttype
>+                     FILTER css_class_quote UNLESS attachment.isurl %]

The W3C CSS validator accepts .bz_contenttype_image\/png as a valid class name, so this is technically acceptable, but replacing / by _ is probably a good idea.

r=LpSolit with attachment.contenttype.replace('/', '_') instead of attachment.contenttype alone. Attach a new patch and carry forward my r+.

Comment 5

[Reed Loden [:reed]]

Attachment: wrong patch

Comment 6

[Reed Loden [:reed]]

Attachment: patch - v3

The real v3.

Comment 7

[Frédéric Buclin]

Comment on attachment 412605 [details] [diff] [review]
patch - v3

Per reed's suggestion on IRC, fixing css_class_quote directly is indeed a better place. r=LpSolit

Comment 8

[Reed Loden [:reed]]

tip:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.96; previous revision: 1.95
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.43; previous revision: 1.42
done

Comment 9

[Reed Loden [:reed]]

Similar to bug 516635 (same reason), I would like to have this on 3.4, too, especially since bmo is using it.

Comment 10

[Max Kanat-Alexander]

The changes to css_class_quote shouldn't go to 3.4. The additional CSS classes aren't a huge deal, I suppose.

One reason that I'm slightly loathe to approve seemingly harmless template changes on stable branches is that they can wreak havoc with local customizations, sometimes, and during stable point-release upgrades, you don't expect havoc (even minor havoc).

Comment 11

[Frédéric Buclin]

OK, so let's take it for 3.6 only.