ASSERTION: Destroying non-empty block list in nsMediaCacheStream::BlockList::~BlockList

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta4-fixed)

Details

Attachments

(1 attachment)

We saw this in a test run of test_mozLoadFrom.html. It leads to all sorts of badness.

The problem is that when when streams are sharing a resource, and you close one of the streams, a block can arrive for the resource and be added to the stream after it's closed. This corrupts media cache state.
Blocks: 518659, 528261
Assignee: nobody → roc
Flags: blocking1.9.2+
Created attachment 412754 [details] [diff] [review]
fix

Don't iterate through closed streams when searching from streams that are sharing a given resource ID.
Attachment #412754 - Flags: review?(chris.double)

Updated

8 years ago
Attachment #412754 - Flags: review?(chris.double) → review+
Whiteboard: [need landing]
http://hg.mozilla.org/mozilla-central/rev/8456ce23a1ec
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [need landing] → [need 192 landing]
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/357a22fd0e39
status1.9.2: --- → final-fixed
Whiteboard: [need 192 landing]
You need to log in before you can comment on or make changes to this bug.