529215 - fails to open non-mozilla extension (add-on) home pages

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Stefan Plewako [:stef]]

When extension em:homepageURL is set to site with domain other than *mozilla.org in install.rdf, Shredder silently fails to open it (after click in Tools → Addons → Extensions → extension context menu → visit home page).

Additionally, homepage link in about extension default dialog is red.

Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1.5) Gecko/20091116 Shredder/3.0.1pre

Comment 1

[Mark Banner (:standard8)]

WFM with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.1.5) Gecko/20091112 Lightning/1.0pre Thunderbird/3.0

Comment 2

[Ludovic Hirlimann [:Usul]]

WFM with RC1 on OpenSuse and MacOSX.

Stefan - any error messages in your Tools -> Error console when this happens ?

Comment 3

[Stefan Plewako [:stef]]

I have failed to isolate the issue (assuming that's not intentional) so far, but have clean (as I believe) repro steps at least.

Testcase:
1a. Create profile testA, install http://trash.splewako.com/bmo.529215.fail.xpi
1b. Tools → Addons → Extensions → extension context menu → visit home page.
1c. Nothing happens.
2a. Create profile testB, install http://trash.splewako.com/bmo.529215.pass.xpi
2b. Tools → Addons → Extensions → extension context menu → visit home page
2c. The page will be opened.

I can reproduce this on linux (Fedora) and winxp, there is no visible difference between 3.0pre, rc1build1 and 3.0.1pre builds.

The second xpi has only updated em:homepageURL tag in install.rdf file.

(In reply to comment #2)
> any error messages in your Tools -> Error console when this happens ?

Nothing.

Comment 4

[Ludovic Hirlimann [:Usul]]

Work:Testcases ludo$ diff -u install.rdf install.rdf.pass 
--- install.rdf	2009-11-17 05:47:31.000000000 +0100
+++ install.rdf.pass	2009-11-17 20:12:15.000000000 +0100
@@ -8,7 +8,7 @@
     <em:version>0.1.0</em:version>
     <em:creator>Stefan Plewako</em:creator>
     <em:description>Rozszerzenie dla Huberta</em:description>
-    <em:homepageURL>http://splewako.com</em:homepageURL>
+    <em:homepageURL>https://bugzilla.mozilla.org/show_bug.cgi?id=529215</em:homepageURL>


Confirming on RC1 build2. Mark as this code is shared with FF shall we move this bug to toolkit ?

Comment 5

[Mark Banner (:standard8)]

No, I'm not convinced this is toolkit yet, unless you can find a similar failure mode in FF 3.5...

Comment 6

[Stefan Plewako [:stef]]

(In reply to comment #5)
> No, I'm not convinced this is toolkit yet, unless you can find a similar
> failure mode in FF 3.5...

Not yet/didn't try, at least not exactly with this xpi (but with similar and fail to repro).
Anyway - just wondering if it might be somehow related to bug 516776.

Comment 7

[Mark Banner (:standard8)]

I've just been doing some digging around this bug.

I compared what happened with the DOMI extension's home page (https://developer.mozilla.org/En/DOM_Inspector) and your 'bad' extension's home page (http://splewako.com/).

It turns out that the DOMI one has a content type of "text/plain", but yours is "application/xhtml+xml".

When I coded up mailContentHandler.js to deal with handling of the types, I think I copied it from nsBrowserContentHandler.js, however I didn't copy handling of all the content types - so I didn't handle "application/xhtml+xml" for one.

I obviously therefore need to go back over the list in nsBrowserContentHandler.js and work out which ones we really want. I also need to come up with some unit tests for this which may take a while as I haven't really got anything to base these on.

Comment 9

[Wayne Mery (:wsmwk)]

Axel, have you ever seen anything like this?  (I don't think I have)

Comment 10

[Axel Grude]

(In reply to Wayne Mery (:wsmwk) from comment #9)
> Axel, have you ever seen anything like this?  (I don't think I have)

No, I think the way it works now is 
1) Open Extensions Tab
2) click More
3) click on the homepage link e.g. http://quickfilters.mozdev.org/index.html

it always opened a new browser tab in Thunderbird for me, which is expected behavior.

Comment 11

[Axel Grude]

(In reply to Axel Grude from comment #10)
> (In reply to Wayne Mery (:wsmwk) from comment #9)
> > Axel, have you ever seen anything like this?  (I don't think I have)
> 
> No, I think the way it works now is 
> 1) Open Extensions Tab
> 2) click More
> 3) click on the homepage link e.g. http://quickfilters.mozdev.org/index.html
> 
> it always opened a new browser tab in Thunderbird for me, which is expected
> behavior.

I got another "needinfo" reminder for this bug today to my "indigo" mail address. how do I clear it? 
(Is it possible that I have 2 separate bugzilla accounts? I am currently logged in with my gmail profile. If this was the case, is there any way I can unify them into one)

Comment 12

[Axel Grude [:realRaven]]

(In reply to Axel Grude from comment #11)
> (In reply to Axel Grude from comment #10)
> > (In reply to Wayne Mery (:wsmwk) from comment #9)
> > > Axel, have you ever seen anything like this?  (I don't think I have)
> I got another "needinfo" reminder for this bug today to my "indigo" mail
> address. how do I clear it? 
> (Is it possible that I have 2 separate bugzilla accounts? I am currently
> logged in with my gmail profile. If this was the case, is there any way I
> can unify them into one)
now logged on with mny other (original) profile. Waynee if you add me to bugs can you use my gmail profile in future? One problem is that all Thunderbird patches I have written were under indigo, not sure how to put these together.

Comment 13

[Wayne Mery (:wsmwk)]

Thanks for checking.