529742 - Vary update frequency and rate prefs between releases and nightly/unofficial builds

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

I'm hoping to land bug 407875 on the 1.9.2 branch. The patches in bug 407875 should be enough to go on and don't hesitate to ping me on irc if there are any questions

Comment 1

[Robert Strong (they/them - no direct email)]

Note: Bug 529942 will move (hopefully soon) the two new attributes from nsIApplicationUpdateService2 to nsIApplicationUpdateService on trunk

Comment 2

[Mark Banner (:standard8)]

Setting as blocking-tb3.1 as this feels like something we should just port and have included.

Comment 3

[Robert Strong (they/them - no direct email)]

If you would like me to fix this I should have time in the next week or two.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch - untested

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Rob, is this something you're likely to have time to poke at some more in the coming weeks?

Comment 6

[Robert Strong (they/them - no direct email)]

Dan, I already posted a patch and requested review. You want to review it? ;)

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Heh, I just noticed the "in progress" verbiage and assumed it wasn't up for review.  I'll let Phil keep the honors (thanks, Phil!).

Comment 8

[Phil Ringnalda (:philor)]

Most pathetic moment in my pathetic review career (so far): I was struggling to unrot it, because I'd look at the rejects, and then the file, and wtf, the rejects weren't rejected, they were right _there_, since I had actually already ported a few bits of it in bug 536078.

Comment 9

[Phil Ringnalda (:philor)]

So, yay me, I actually fixed the blocker part of this and what the summary said it was about in bug 536078 (not entirely clear I knew I was, though "since canCheckForUpdates is a considerably better thing than canUpdate" sounds like maybe I did). Resummarizing for what's left in the patch, which is

* check for updates every 8 hours in nightlies, every 24 in releases
* download a chunk in the background every 60 seconds in nightlies, every 600 seconds in releases
* use getthunderbird.com as the manual URL in releases, and the existing http://www.mozillamessaging.com/%LOCALE%/%APP%/ with the existing comment about wanting to change it in nightlies

The first two are straightforward enough, though we need to update the patch since we have unofficial branding now, too, but the third is more of a call for gozer+rebron+dmose, so I split it off to bug 552333.

Comment 10

[Phil Ringnalda (:philor)]

Attachment: time prefs

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 432477 [details] [diff] [review]
time prefs

I actually meant to port this ages ago. Oh well.

Please can you ping me on irc or send me email to remind me to notify metrics when this lands. I suspect they don't need to know about it, but just in case.

Comment 12

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/da835c2b8de2