Closed Bug 529933 Opened 12 years ago Closed 9 years ago

[Mac] "File" toolbar button shows old folder after bug 491294

Categories

(Thunderbird :: Toolbars and Tabs, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 12.0

People

(Reporter: ts.bugzilla, Assigned: andreasn)

References

Details

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b3) Gecko/20091115 Firefox/3.6b3
Build Identifier: 

Bug 491294 brought updated Leopard-style folder icons for the folder pane, the compose window toolbar and probably some more. But the "File..." button on the main toolbar was omitted.

Reproducible: Always
Flags: blocking-thunderbird3?
Blocks: 491294
Attachment #413580 - Flags: ui-review?(clarkbw)
to ease ui review
Not blocking on this, though we could potentially take it for a point release of 3.0 (undecided as of yet).
Flags: blocking-thunderbird3? → blocking-thunderbird3-
Attachment #413580 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

looks good from the screenshots, thanks andreas!
Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Confirming per the comments.
Was this patch integrated or not?
Attachment #413580 - Flags: superreview?(mbanner)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Please don't ask by requesting review, just ask the author of the patch (making sure they are cc'ed or assigned), if it is still wanted.
Attachment #413580 - Flags: superreview?(mbanner)
Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Totally forgot about this bug.
Asking bwinton for review here.
Attachment #413580 - Flags: review?(bwinton)
Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Review of attachment 413580 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, although I admit I haven't tested out the patch on a recent build.

I'm going to say r=me, but I would like to see a link to a try-server build that I could run a quick check on.  :)
Attachment #413580 - Flags: review?(bwinton) → review+
(In reply to Andreas Nilsson (:andreasn) from comment #9)
> Here you go!
> 
> http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/nisses.
> mail@home.se-31f8aa7f478e/try-comm-central-macosx-debug/
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Why is this not checked-in ?
checkin-needed missing?
I suspect forgotten or was waiting for Blake to test.

In any case, I suspect it needs a new patch (andreasn?)
Yup, graphics needs to be slightly updated, since we got at least one new icon on the toolbar.
new patch. Carrying over review and ui-review.
Attachment #413580 - Attachment is obsolete: true
Attachment #591068 - Flags: ui-review+
Attachment #591068 - Flags: review+
so adding the checkin-needed :-)
Keywords: checkin-needed
Attachment #591068 - Attachment is patch: true
Checked in: http://hg.mozilla.org/comm-central/rev/feb02f829940
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.