529933 - [Mac] "File" toolbar button shows old folder after bug 491294

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Thomas Stache]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b3) Gecko/20091115 Firefox/3.6b3
Build Identifier: 

Bug 491294 brought updated Leopard-style folder icons for the folder pane, the compose window toolbar and probably some more. But the "File..." button on the main toolbar was omitted.

Reproducible: Always

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: new folder icons for main toolbar and compose window

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of before and after

to ease ui review

Comment 3

[Mark Banner (:standard8)]

Not blocking on this, though we could potentially take it for a point release of 3.0 (undecided as of yet).

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

looks good from the screenshots, thanks andreas!

Comment 5

[:aceman]

Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Confirming per the comments.
Was this patch integrated or not?

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Please don't ask by requesting review, just ask the author of the patch (making sure they are cc'ed or assigned), if it is still wanted.

Comment 7

[Andreas Nilsson (:andreasn)]

Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Totally forgot about this bug.
Asking bwinton for review here.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 413580 [details] [diff] [review]
new folder icons for main toolbar and compose window

Review of attachment 413580 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, although I admit I haven't tested out the patch on a recent build.

I'm going to say r=me, but I would like to see a link to a try-server build that I could run a quick check on.  :)

Comment 9

[Andreas Nilsson (:andreasn)]

Here you go!

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-31f8aa7f478e/try-comm-central-macosx-debug/

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to Andreas Nilsson (:andreasn) from comment #9)
> Here you go!
> 
> http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/nisses.
> [e-mail]-31f8aa7f478e/try-comm-central-macosx-debug/

Comment 11

[Ludovic Hirlimann [:Usul]]

Why is this not checked-in ?

Comment 12

[:aceman]

checkin-needed missing?

Comment 13

[Mark Banner (:standard8)]

I suspect forgotten or was waiting for Blake to test.

In any case, I suspect it needs a new patch (andreasn?)

Comment 14

[Andreas Nilsson (:andreasn)]

Yup, graphics needs to be slightly updated, since we got at least one new icon on the toolbar.

Comment 15

[Andreas Nilsson (:andreasn)]

Attachment: new folder icons for main toolbar and compose window (v2)

new patch. Carrying over review and ui-review.

Comment 16

[Ludovic Hirlimann [:Usul]]

so adding the checkin-needed :-)

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/feb02f829940