529989 - Collect email addresses and send them to Socorro with reports

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Sam says that Socorro is storing email addresses again, and he's filed bug 529986 to get that info exposed in reports when you're logged in.  We should start collecting them and sending them to Socorro.

I think I recall Stuart saying that there was some plist key or something that seemed "simple" to me that controlled whether the email UI showed up.  Stuart, please correct my recollection.  If it's not too difficult, I'd really like it in 2.0.1.

We'd also have to fix the privacy policy URL; it's "hard-coded" in the Localizable.strings file to http://www.google.com/privacypolicy.html, but I think the benefit of having emails outweighs the l10n hit for 2.0.1.  (It'd be great if ultimately upstream that URL became configurable somewhere outside of the .strings file so consumers didn't have to fork the file, but it's an easier fork.)

Comment 1

[Stuart Morgan]

BreakpadRequestEmail = YES in the plist should be all it takes, IIRC. We'd need to double-check that the key-mapping for Socorro in breakpad includes email and does the right thing though.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart's going to try to fix both of these this weekend, and if so, we'll take them in 2.0.1.

Comment 3

[Stuart Morgan]

Attachment: fix

Should work; I'll have someone verify that the address actually shows up at the server end tomorrow. I had to add breakpad mapping for the email field, and make the email placeholder string localizable.

There's also an addition to the breakpad strings file:
"emailPlaceholder" = "optional";
(it's UTF-16, so it won't diff).

I'll be patching the two breakpad issues upstream shortly, but I don't want to rev breakpad in a minor update unless we run into a real need to.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Don't forget to update the privacy url string, too:

"privacyPolicyURL" = "http://caminobrowser.org/legal/privacy/";

Comment 5

[Stuart Morgan]

(In reply to comment #4)
> Don't forget to update the privacy url string, too:
> 
> "privacyPolicyURL" = "http://caminobrowser.org/legal/privacy/";

Done locally; thanks for the reminder.

Comment 6

[Marcello Testi]

Though ugly as a privacy statement can be, we should have it localized. Before opening a new bug for it, I'd like to know if we can have it on the website and if we can have a sort of content negotiation so that the URL remains the same for any language

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> Though ugly as a privacy statement can be, we should have it localized. Before
> opening a new bug for it, I'd like to know if we can have it on the website and
> if we can have a sort of content negotiation so that the URL remains the same
> for any language

That's something to bring up in bug 522978, not here.

Comment 8

[Stuart Morgan]

Sam checked my test submission, and the email is there.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 413954 [details] [diff] [review]
fix

sr=pink

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk and CAMINO_2_0_BRANCH for Stuart, with both of the Localizable.strings changes.

Stuart, should I file a bug upstream about making the privacyPolicyURL something that gets pulled from the host app's Info.plist like BreakpadVendor rather than being hard-coded in the framework to Google's URL?

Comment 11

[Stuart Morgan]

Probably so, for consistency with the vendor stuff.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #11)
> Probably so, for consistency with the vendor stuff.

Filed http://code.google.com/p/google-breakpad/issues/detail?id=352 on that.

Updated http://code.google.com/p/google-breakpad/issues/detail?id=349 on another unlocalizable string we've been missing all along, and filed http://code.google.com/p/google-breakpad/issues/detail?id=351 on key loop problems we've also been missing all along, both of which I discovered while testing this fix in 2.0.1rc1.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sync crash_report_sender.m and sender's strings with what Stuart committed upstream r475

(In reply to comment #12)
> Updated http://code.google.com/p/google-breakpad/issues/detail?id=349 on
> another unlocalizable string we've been missing all along, and filed

Stuart, I'd like to take this second part of your fix for 349 so that anyone submitting a translation to upstream in bug 525031 actually has all the current strings.  Any translator who doesn't care can just ignore it, since we're no worse off adding localizability than before when it was unlocalizable.

Comment 14

[Stuart Morgan]

Comment on attachment 419765 [details] [diff] [review]
Sync crash_report_sender.m and sender's strings with what Stuart committed upstream r475

sr=smorgan

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 419765 [details] [diff] [review]
Sync crash_report_sender.m and sender's strings with what Stuart committed upstream r475

Landed on cvs trunk and CAMINO_2_0_BRANCH.