Closed Bug 530352 Opened 12 years ago Closed 8 years ago

Eliminate last nsFileSpec and nsIFileSpec (references) from Core

Categories

(Core :: XUL, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: sgautherie, Assigned: Cykesiopka)

References

()

Details

Attachments

(1 file)

This bug is for the comments (and maybe related code) only:
{
/parser/htmlparser/tests/outsinks/Convert.cpp
    * line 62 -- // until I find out how to use nsFileSpec:
    * line 285 -- // until I find out how to use nsFileSpec:

/widget/src/xpwidgets/nsTransferable.cpp
    * line 89 -- //nsIFileSpec * cacheFile = GetFileSpec(mCacheFileName);

/extensions/java/xpcom/interfaces/Makefile.in
    * line 107 -- # interface nsIFileSpec.
}
There seems to be only one last trace of this:
http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsTransferable.cpp#90

Should the comment just be removed?
Component: General → XP Toolkit/Widgets: XUL
QA Contact: general → xptoolkit.xul
(In reply to :aceman from comment #1)
> Should the comment just be removed?

Most likely. Or reviewer should hint to which replacement code he would like instead.
Vladimir, can you help us?
Flags: needinfo?(vladimir)
Don't know if this is what is desired, but I already made the patch...
Attachment #738832 - Flags: review?(vladimir)
Status: NEW → ASSIGNED
Flags: needinfo?(vladimir)
Keywords: checkin-needed
QA Contact: cykesiopka
Assignee: nobody → cykesiopka
QA Contact: cykesiopka
https://hg.mozilla.org/mozilla-central/rev/7621b9481f50
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.