Now that we have nsIFile, we should eliminate all the old nsFileSpec stuff: http://lxr.mozilla.org/seamonkey/ident?i=nsFileSpec A lot of this is changing: nsFileSpec fs(path); to: nsCOMPtr<nsILocalFile> fs; rv = NS_NewLocalFile(path, getter_AddRefs(fs)); and changing the parameter types from nsFileSpec& to nsIFile*. Also, we should change the functions in xpcom/io/nsIFileStream.h (e.g. NS_NewTypicalInputFileStream) to the new functions in netwerk/base/public/nsIFileStreams.idl (e.g. NS_NewLocalFileInputStream). Help on this one greatly appreciated.
I'll take this bug as part of the nsIFIle stuff i'm doing. I am also working on getting rid of uconv from io. FileSpec is dependent on uconv nsIFIle is not now. Assign this bug to me. thanks --pete
Assignee: nobody → petejc
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Ok, nsFileSpec is used massively all over the place . . . So this will need to be done in safe step by step stages. First thing i will do is comment all of the API clones that are in nsIFileSpec and change over all of the accessors to use nsIFile. --pete
I think we will have to future this for now . . . --pete
Target Milestone: mozilla0.9.9 → Future
Comment on attachment 129044 [details] [diff] [review] remove unnecessary xpcom_obsolete references (checked in) great!
Attachment #129044 - Flags: review?(dougt) → review+
Comment on attachment 129044 [details] [diff] [review] remove unnecessary xpcom_obsolete references (checked in) Assuming it all builds, sr=me.
Attachment #129044 - Flags: superreview?(bryner) → superreview+
Attachment #129044 - Attachment description: remove unnecessary xpcom_obsolete references → remove unnecessary xpcom_obsolete references (checked in)
Assignee: pete → nobody
Status: ASSIGNED → NEW
QA Contact: nobody → xpcom
Shouldn't nsIFileSpec (note the "I") be removed as well? http://mxr.mozilla.org/seamonkey/source/xpcom/obsolete/nsIFileSpec.idl#39 It's still used in libpref, see bug 214796.
Summary: eliminate nsFileSpec → eliminate nsFileSpec and nsIFileSpec
AFAIK xpcom/obsolete is only used by mailnews and is in the process of being removed. We certainly don't build it as part of XULRunner/Firefox any more. I don't think this bug is worth tracking independently.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.