Closed
Bug 530416
Opened 16 years ago
Closed 14 years ago
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in the rest of mozilla-central
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: lusian, Assigned: lusian)
References
Details
Attachments
(1 obsolete file)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier:
Please see Bug #512106.
Reproducible: Always
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #413926 -
Flags: review?
|
||
Updated•16 years ago
|
Assignee: nobody → lusian
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Updated•15 years ago
|
Attachment #413926 -
Flags: review? → review?(dao)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 413926 [details] [diff] [review]
Search&Replace, 0
I'm not the right reviewer for this
Attachment #413926 -
Flags: review?(dao)
|
|
||
Updated•15 years ago
|
Attachment #413926 -
Flags: review?(brendan)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 413926 [details] [diff] [review]
Search&Replace, 0
Why is Mork still darkening our source tree?
I defer to Benjamin on this kind of patch.
/be
Attachment #413926 -
Flags: review?(brendan) → review?(benjamin)
|
||
Comment 4•15 years ago
|
||
Comment on attachment 413926 [details] [diff] [review]
Search&Replace, 0
As I noted in one of these bugs, I do not think NS_MIN/MAX are good names (because they still look like macros). There is a patch (reviewed, perhaps?) in one of these bugs to make mozilla::min/max and use that.
Attachment #413926 -
Flags: review?(benjamin) → review-
|
||
Comment 5•14 years ago
|
||
Fixed by bug 661584.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #413926 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•