The default bug view has changed. See this FAQ.

Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX, in mozilla-central

VERIFIED FIXED

Status

()

Core
General
--
minor
VERIFIED FIXED
8 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: Jae-Seong Lee-Russo)

Tracking

(Blocks: 1 bug, {meta})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 obsolete attachment)

(Reporter)

Description

8 years ago
+++ This bug was initially created as a clone of Bug #512106 +++

See that bug about why and how to do it...
(Reporter)

Updated

8 years ago
Whiteboard: [good first bug] [first, file blocking bugs]
(Reporter)

Updated

8 years ago
Depends on: 518504
(Assignee)

Comment 1

8 years ago
Created attachment 402894 [details] [diff] [review]
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in mozilla-central

Automatically replaced PR_MIN/PR_MAX, and then had to add changes manually (#include "nsAlgorithm.h", type conversions).

I could build Firefox on Windows XP.  The patch needs to be tested on the Try Server.
(Reporter)

Updated

7 years ago
Assignee: nobody → lusian
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [good first bug] [first, file blocking bugs] → [c-n: to try] [first, file blocking bugs] [good first bug]
This patch doesn't apply anymore:

patching file xpcom/string/src/nsTSubstring.cpp
Hunk #1 succeeded at 475 (offset 1 line).
Hunk #3 succeeded at 526 (offset 1 line).
Hunk #4 FAILED at 544.

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1258635928.1258636234.11984.gz
Keywords: checkin-needed
Whiteboard: [c-n: to try] [first, file blocking bugs] [good first bug] → [first, file blocking bugs] [good first bug]
(Assignee)

Updated

7 years ago
Attachment #402894 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Depends on: 530290
(Assignee)

Updated

7 years ago
Depends on: 530293
(Assignee)

Updated

7 years ago
Depends on: 530296
(Assignee)

Updated

7 years ago
Depends on: 530297
(Assignee)

Updated

7 years ago
Depends on: 530299
(Assignee)

Updated

7 years ago
Depends on: 530300
(Assignee)

Updated

7 years ago
Depends on: 530305
(Assignee)

Updated

7 years ago
Depends on: 530360
(Assignee)

Updated

7 years ago
Depends on: 530361
(Assignee)

Updated

7 years ago
Depends on: 530363
(Assignee)

Updated

7 years ago
Depends on: 530364
(Assignee)

Updated

7 years ago
Depends on: 530372
(Assignee)

Updated

7 years ago
Depends on: 530373
(Assignee)

Updated

7 years ago
Depends on: 530374
(Assignee)

Updated

7 years ago
Depends on: 530375
(Assignee)

Updated

7 years ago
Depends on: 530382
(Assignee)

Updated

7 years ago
Depends on: 530384
(Assignee)

Updated

7 years ago
Depends on: 530385
(Assignee)

Updated

7 years ago
Depends on: 530386
(Assignee)

Updated

7 years ago
Depends on: 530387
(Assignee)

Updated

7 years ago
Depends on: 530389
(Assignee)

Updated

7 years ago
Depends on: 530392
(Assignee)

Updated

7 years ago
Depends on: 530394
(Assignee)

Updated

7 years ago
Depends on: 530408
(Assignee)

Updated

7 years ago
Depends on: 530409
(Assignee)

Updated

7 years ago
Depends on: 530410
(Assignee)

Updated

7 years ago
Depends on: 530411
(Assignee)

Updated

7 years ago
Depends on: 530415
(Assignee)

Updated

7 years ago
Depends on: 530416
Fixed by bug 661584.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Depends on: 661584
Resolution: --- → FIXED
(Reporter)

Comment 4

6 years ago
To be explicit, what about (other) remaining cases? (Mostly in (NSPR and) NSS.)

"Found 38 matching lines in 11 files "
The others are in NSS/NSPR (which I was under the impression can't use a core specific include, due to third party users of them) & non C++ code. As such, I don't believe any of the others can be changed - though if that is not the case, I'm happy to try and implement whatever you suggest.
(Reporter)

Updated

5 years ago
Blocks: 707395
(Reporter)

Updated

5 years ago
Blocks: 707396
(Reporter)

Comment 6

5 years ago
(In reply to Ed Morley [:edmorley] from comment #5)
> The others are in NSS/NSPR (which I was under the impression can't use a
> core specific include, due to third party users of them) & non C++ code. As
> such, I don't believe any of the others can be changed - though if that is
> not the case, I'm happy to try and implement whatever you suggest.

Right: "Found 39 matching lines in 12 files"
/modules/libreg/src/nr_bufio.c
/ipc/chromium/src/base/third_party/nspr/prtypes.h
2 * /nsprpub/pr/...
/docshell/shistory/src/nsSHistory.cpp : I filed bug 707395.
7 * /security/nss/

V.Fixed
Status: RESOLVED → VERIFIED
Whiteboard: [first, file blocking bugs] [good first bug]
(Reporter)

Updated

5 years ago
Blocks: 708274
(Reporter)

Updated

5 years ago
Blocks: 708277
(Reporter)

Comment 7

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> V.Fixed

Arg, I probably checked PR_MIN only :-/
I filed 2  new blocking bugs!
You need to log in before you can comment on or make changes to this bug.