518502 - Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX, in mozilla-central

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

+++ This bug was initially created as a clone of Bug #512106 +++

See that bug about why and how to do it...

Comment 1

[Jae-Seong Lee-Russo]

Attachment: Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in mozilla-central

Automatically replaced PR_MIN/PR_MAX, and then had to add changes manually (#include "nsAlgorithm.h", type conversions).

I could build Firefox on Windows XP.  The patch needs to be tested on the Try Server.

Comment 2

[Dão Gottwald [:dao]]

This patch doesn't apply anymore:

patching file xpcom/string/src/nsTSubstring.cpp
Hunk #1 succeeded at 475 (offset 1 line).
Hunk #3 succeeded at 526 (offset 1 line).
Hunk #4 FAILED at 544.

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1258635928.1258636234.11984.gz

Comment 3

[Ed Morley [:emorley]]

Fixed by bug 661584.

Comment 4

[Serge Gautherie (:sgautherie)]

To be explicit, what about (other) remaining cases? (Mostly in (NSPR and) NSS.)

"Found 38 matching lines in 11 files "

Comment 5

[Ed Morley [:emorley]]

The others are in NSS/NSPR (which I was under the impression can't use a core specific include, due to third party users of them) & non C++ code. As such, I don't believe any of the others can be changed - though if that is not the case, I'm happy to try and implement whatever you suggest.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Ed Morley [:edmorley] from comment #5)
> The others are in NSS/NSPR (which I was under the impression can't use a
> core specific include, due to third party users of them) & non C++ code. As
> such, I don't believe any of the others can be changed - though if that is
> not the case, I'm happy to try and implement whatever you suggest.

Right: "Found 39 matching lines in 12 files"
/modules/libreg/src/nr_bufio.c
/ipc/chromium/src/base/third_party/nspr/prtypes.h
2 * /nsprpub/pr/...
/docshell/shistory/src/nsSHistory.cpp : I filed bug 707395.
7 * /security/nss/

V.Fixed

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #6)
> V.Fixed

Arg, I probably checked PR_MIN only :-/
I filed 2  new blocking bugs!