530533 - Add pref to control whether addEngine prompts to "use immediately"

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Fennec doesn't really expose the "current engine" concept - all of our search engines are always visible, and none of them is "selected" in any way. So the addEngine dialog's checkbox offering to "start using it right away" doesn't really make much sense. I'd like to make that preffable so that Fennec can hide it.

It pains me slightly to be going the pref route here, but I don't think there are any better options for something that we'd like landed on 1.9.2 before shipping Fennec 1.0.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I used the somewhat generic "hasNoCurrentEngine" in case this ends up applying to more than just the prompt.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 414050 [details] [diff] [review]
patch

I guess the ideal thing to do here would be to have search service consumers each implement this UI, but this is certainly good enough for now.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/47477a31989f

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 414050 [details] [diff] [review]
patch

a192=beltzner

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-1.9.2/rev/d00fcec04856

Comment 7

[Samuel Sidler (old account; do not CC)]

These bugs landed after b4 was cut. Moving flag out.