Closed Bug 530846 Opened 10 years ago Closed 10 years ago

addEngine confirmation dialog shouldn't offer to "use this engine now"

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
fennec1.0

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

patch
1.75 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Since we don't have the concept of a "selected" engine the way Firefox does - all our engines are always exposed. Just means flipping the pref being added in bug 530533.
Attached patch patch — — Splinter Review 
set the pref
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #414410 - Flags: review?(mark.finkle)
Attachment #414410 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/0809aafe9d9b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
I've tried flipping the "browser.search.noCurrentEngine" pref from true to false and didn't see anything different in the identity panel, awesome bar or add-ons manager post-restart. What is supposed to happen when not "exposing" the engine?
The pref controls whether there's a "use now" checkbox in the add engine confirmation dialog that you see when clicking on an engine at http://mycroft.mozdev.org/dlstats.html.
You need to log in before you can comment on or make changes to this bug.