Closed
Bug 530713
Opened 16 years ago
Closed 16 years ago
nanojit: fix LirReader::read() badness
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
2.13 KB,
patch
|
Details | Diff | Splinter Review |
In the non-DEBUG case, for LIR_start, _i ends up pointing to junk and we then do _i->opcode(). Usually it works because it only causes problems when the bogus _i->opcode() evaluates to LIR_skip, which is rare.
This patch fixes it. Based on IRC discussions with Ed and Rick. insSizes[] is now in ::read() rather than global because it special-cases LIR_start in a way that isn't widely applicable.
Attachment #414170 -
Flags: review?(edwsmith)
|
||
Updated•16 years ago
|
Attachment #414170 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 1•16 years ago
|
||
This version keeps the global insSizes[], as required by Tamarin (but it's ugly and should be removed eventually).
Attachment #414170 -
Attachment is obsolete: true
Attachment #414173 -
Flags: review?(edwsmith)
|
|
||
Comment 2•16 years ago
|
||
removing insSizes is okay like in the first patch; CodegenLIR.cpp in TR does use it, but i'll fix that up when i import this patch from nanojit-central. our usage of it is hacky, so this is a good excuse as any to clean it up.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Whiteboard: fixed-in-nanojit
|
|
||
Comment 4•16 years ago
|
||
pushed to tamarin http://hg.mozilla.org/tamarin-redux/rev/40273d83a431
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
|
|
||
Updated•16 years ago
|
Attachment #414173 -
Flags: review?(edwsmith)
|
|
Assignee | |
Comment 6•16 years ago
|
||
Whiteboard: fixed-in-nanojit, fixed-in-tamarin → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
|
|
Assignee | |
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•