530948 - Changing add-on to self-hosted doesn't clear recommended/featured status

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

These add-ons probably don't follow our policies now that they're self-hosted:

https://addons.mozilla.org/en-US/firefox/addon/4391
https://addons.mozilla.org/en-US/firefox/addon/5246
https://addons.mozilla.org/en-US/firefox/addon/6111

In general, we shouldn't recommend or feature add-ons we have no control over. I guess there are exceptions, but this isn't the case.

I think that changing an add-on to self-hosted shouldn't preserve its recommended or featured status.

Comment 1

[Jeff Balogh (:jbalogh)]

Removing featured status was also part of the spec.

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #1)
> Removing featured status was also part of the spec.

I don't think so: http://docs.google.com/Doc?id=dfntthnr_26gdrd3kfv&pli=1

Though of course that makes sense. I'll have a patch ready soon.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This should do the trick for both global recommendations and per-category features.

Comment 4

[Fred Wenzel [:wenzel]]

r56863 !

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Hosted/Recommended (before)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Self-hosted/Listed (after)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; bug 529871 covers the application-compatibility range not sticking for self-hosted/listed add-ons.