Closed Bug 531209 Opened 10 years ago Closed 10 years ago

Change Weave Sync bookmark link

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

defect
Not set

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0
Tracking Status
fennec 1.0+ ---

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

See bug 515652 comment 9. Should point to:

http://www.mozilla.com/en-US/m/sync/

Note that putting this in default bookmarks means that on first run this will be added to user bookmarks, and we won't really ever be able to update or get rid of this link, so we should be prepared to keep the link working for a long time.
tracking-fennec: ? → 1.0+
(In reply to comment #0)

> http://www.mozilla.com/en-US/m/sync/

This page is currently 404
Attached patch patchSplinter Review
This page isn't online yet.

Do we know whether this page will be localized? One advantage of linking to AMO is that most of the site is already localized...
Assignee: nobody → gavin.sharp
Attachment #415970 - Flags: review?(mark.finkle)
Attachment #415970 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/722c0880ace6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091215 Firefox/3.6b5pre Fennec/1.0b6pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
I have weave installed and the only Weave bookmark in place is the one to the Weave Synch AMO page. Are you sure that this bug is fixed?
This is actually one of the default bookmarks that comes up as part of a new profile. It has nothing to do with installing weave.
Well, I have weave installed but don't have the bookmark.
Hmm, can you try the following:

1. to keep your profile; move it (go to "cd ~/.mozilla/fennec )
2. delete the fennec/ folder within /.mozilla/ 
3. then start up fennec
4. Go to the Awesome Bar
5. click on See All Bookmarks
This profile *was* clean.

What are you looking for? You gave steps but no expected result or what you expect me to tell you.
To be clear, I took a clean profile (clean yesterday) and installed weave on it.
The Weave Addon is not related to this bug at all. Our default bookmark set (that you only get with newly created profiles) contains a "Firefox: Synchronize using Weave" bookmark that used to point to the Weave Page on AMO. This bug updated the URL to point to http://www.mozilla.com/@AB_CD@/m/sync/ instead.

So the steps to verify are:
1) Create a new profile
2) Awesomebar, "Show all bookmarks"
3) Click the "Firefox: Synchronize using Weave"

Previous results: https://addons.mozilla.org/en-US/mobile/addon/10868 loads
Expected results: http://www.mozilla.com/en-US/m/sync/ loads
Component: General → Bookmarks
Assigning to self to create a litmus testcase.
Assignee: gavin.sharp → tchung
(In reply to comment #13)
> Assigning to self to create a litmus testcase.

The assignee field is only for the developer who wrote the patch.
Assignee: tchung → gavin.sharp
We talked about this on irc with blassey and ted. We're experimenting.
Flags: in-litmus? → in-litmus?(tchung)
Added litmus test: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12933
Flags: in-litmus?(tchung) → in-litmus+
You need to log in before you can comment on or make changes to this bug.