531278 - Theme is labeled as version 2.0

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Andreas Nilsson (:andreasn)]

Even though the version of Thunderbird is 3.0, the theme is still called 2.0.
Mark suggested to tie it to the Thunderbird version instead, and it seems to be what Firefox does as well.

Comment 1

[Andreas Nilsson (:andreasn)]

originally reported here http://getsatisfaction.com/mozilla_messaging/topics/default_theme_tb_3_0rc1?utm_content=topic_link&utm_medium=email&utm_source=new_topic

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

This does what Firefox does - use the app version. So if we're 3.1a1pre we'll get "Default 3.1a1pre"; if we're 3.1 we'll get "Default 3.1" etc.

I think we can probably take this for 3.0 once we've got it in on 3.1.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 414734 [details] [diff] [review]
The fix

looks like a good plan to me.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e66810e47afe

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 414734 [details] [diff] [review]
The fix

We should let this bake for a day and then take it on branch as its a minor UI fix.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 414734 [details] [diff] [review]
The fix

a=me for my own patch as this is very low-risk and self contained.

Comment 7

[Mark Banner (:standard8)]

Checked into 1.9.1: http://hg.mozilla.org/releases/comm-1.9.1/rev/4471608dd333
Checked into relbranch: http://hg.mozilla.org/releases/comm-1.9.1/rev/4e1e09c06c0e