Theme is labeled as version 2.0

VERIFIED FIXED in Thunderbird 3

Status

VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: andreasn, Assigned: standard8)

Tracking

Trunk
Thunderbird 3
x86
Linux
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.0 .1-fixed)

Details

(Whiteboard: [fixed RC2 build 1])

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Even though the version of Thunderbird is 3.0, the theme is still called 2.0.
Mark suggested to tie it to the Thunderbird version instead, and it seems to be what Firefox does as well.
(Assignee)

Comment 2

9 years ago
Created attachment 414734 [details] [diff] [review]
The fix

This does what Firefox does - use the app version. So if we're 3.1a1pre we'll get "Default 3.1a1pre"; if we're 3.1 we'll get "Default 3.1" etc.

I think we can probably take this for 3.0 once we've got it in on 3.1.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #414734 - Flags: ui-review?(clarkbw)
Attachment #414734 - Flags: review?(philringnalda)
Comment on attachment 414734 [details] [diff] [review]
The fix

looks like a good plan to me.
Attachment #414734 - Flags: ui-review?(clarkbw) → ui-review+
(Assignee)

Updated

9 years ago
Attachment #414734 - Flags: review?(philringnalda) → review?(bienvenu)

Updated

9 years ago
Attachment #414734 - Flags: review?(bienvenu) → review+
(Assignee)

Updated

9 years ago
status-thunderbird3.0: --- → wanted
(Assignee)

Comment 4

9 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/e66810e47afe
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
(Assignee)

Comment 5

9 years ago
Comment on attachment 414734 [details] [diff] [review]
The fix

We should let this bake for a day and then take it on branch as its a minor UI fix.
Attachment #414734 - Flags: approval-thunderbird3.0.1?
(Assignee)

Comment 6

9 years ago
Comment on attachment 414734 [details] [diff] [review]
The fix

a=me for my own patch as this is very low-risk and self contained.
Attachment #414734 - Flags: approval-thunderbird3.0.1?
Attachment #414734 - Flags: approval-thunderbird3.0.1+
Attachment #414734 - Flags: approval-thunderbird3+
(Assignee)

Comment 7

9 years ago
Checked into 1.9.1: http://hg.mozilla.org/releases/comm-1.9.1/rev/4471608dd333
Checked into relbranch: http://hg.mozilla.org/releases/comm-1.9.1/rev/4e1e09c06c0e
status-thunderbird3.0: wanted → .1-fixed
Whiteboard: [fixed RC2 build 1]
(Assignee)

Updated

9 years ago
Flags: in-testsuite-
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3
Status: RESOLVED → VERIFIED
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.