Closed Bug 531278 Opened 12 years ago Closed 12 years ago

Theme is labeled as version 2.0

Categories

(Thunderbird :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(thunderbird3.0 .1-fixed)

VERIFIED FIXED
Thunderbird 3
Tracking Status
thunderbird3.0 --- .1-fixed

People

(Reporter: andreasn, Assigned: standard8)

Details

(Whiteboard: [fixed RC2 build 1])

Attachments

(1 file)

Even though the version of Thunderbird is 3.0, the theme is still called 2.0.
Mark suggested to tie it to the Thunderbird version instead, and it seems to be what Firefox does as well.
Attached patch The fixSplinter Review
This does what Firefox does - use the app version. So if we're 3.1a1pre we'll get "Default 3.1a1pre"; if we're 3.1 we'll get "Default 3.1" etc.

I think we can probably take this for 3.0 once we've got it in on 3.1.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #414734 - Flags: ui-review?(clarkbw)
Attachment #414734 - Flags: review?(philringnalda)
Comment on attachment 414734 [details] [diff] [review]
The fix

looks like a good plan to me.
Attachment #414734 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #414734 - Flags: review?(philringnalda) → review?(bienvenu)
Attachment #414734 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/e66810e47afe
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 414734 [details] [diff] [review]
The fix

We should let this bake for a day and then take it on branch as its a minor UI fix.
Attachment #414734 - Flags: approval-thunderbird3.0.1?
Comment on attachment 414734 [details] [diff] [review]
The fix

a=me for my own patch as this is very low-risk and self contained.
Attachment #414734 - Flags: approval-thunderbird3.0.1?
Attachment #414734 - Flags: approval-thunderbird3.0.1+
Attachment #414734 - Flags: approval-thunderbird3+
Flags: in-testsuite-
Target Milestone: Thunderbird 3.1a1 → Thunderbird 3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.