531430 - Cancel button while installing addons is not localized

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; es-ES; rv:1.9.2b5pre) Gecko/20091127 Namoroka/3.6b5pre
Build Identifier: 

The "Cancel" button that is shown in the dialogue to install or cancel the installation of an addon is not localized.



Reproducible: Always

Steps to Reproduce:
1. Open Fennec
2. Go to the bookmark for installing Weave
3. Click on install Weave
Actual Results:  
The dialog shows a "Instalar" (in Spanish) and "Cancel" in English.

Expected Results:  
"Cancel" should be localized

The translation should be on chrome/overrides/browser.properties with a new string like: addonsConfirmInstall.cancel

I'm using the latest nightly for es-ES in a N810 device.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Cancel button not localized

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This dialog uses the prompt service's default "cancel" string, so we should end up using:

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/commonDialogs.properties#9

http://mxr.mozilla.org/l10n-central/source/es-ES/toolkit/chrome/global/commonDialogs.properties
and
http://mxr.mozilla.org/l10n-mozilla1.9.2/source/es-ES/toolkit/chrome/global/commonDialogs.properties look OK, though, so I'm not sure what's up here...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Probably related to bug 531667?

Comment 4

[Martijn Wargers (dead)]

I can reproduce this issue, using Fennec1.1b1 on the n900 with the es-es locale.
Weird, because I can see the entity right here:
http://mxr.mozilla.org/l10n-mozilla1.9.2/source/es-ES/mobile/chrome/browser.dtd#43

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this still an issue?

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

This is fixed in latest nightlies in Android…