Crash for profiles with a non-existent non-relative profile location

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Gabri, Assigned: Gabri)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(status1.9.2 beta5-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Steps to reproduce:

- Download and unzip a trunk build on your desktop
- Make a batch file with ("profile" folder must not exist):
  start C:\......\firefox\firefox.exe -profile profile

Message returned: "Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system.".
(Assignee)

Comment 1

8 years ago
It should create the "profile" folder automatically or display to the user if he wants to create it.
(Assignee)

Comment 2

8 years ago
Created attachment 414916 [details] [diff] [review]
proposed patch

It works, I hope benjamin could review it.
Attachment #414916 - Flags: review?(benjamin)
Attachment #414916 - Flags: review?(benjamin) → review+
Assignee: nobody → gabri.best
Component: Profile: BackEnd → Startup and Profile System
Keywords: checkin-needed
Product: Core → Toolkit
QA Contact: profile-manager-backend → startup
Dup of bug 278860?
No, not at all.
(In reply to comment #4)
> No, not at all.

Benjamin Smedberg, what is difference of this bug from problem of bug 278860?
Proposed patch to this bug never covers problem of bug 278860?
Or you saying that "Firefox is already running, but is not responding. ..." when non-relative path(this bug) is absolutely different problem from the message/phenomenon when relative path(bug 278860)?
Or this bug is really for crash even though Crash-ID is not reported to this bug?
(Assignee)

Comment 6

8 years ago
This bug is specifically about -profile so it's not a dup of bug 278860.
I'll take a look to bug 278860 soon :)
(Assignee)

Updated

8 years ago
Attachment #414916 - Flags: approval1.9.2?
Comment on attachment 414916 [details] [diff] [review]
proposed patch

a192=beltzner
Attachment #414916 - Flags: approval1.9.2? → approval1.9.2+
(In reply to comment #6)
> I'll take a look to bug 278860 soon :)

Gabriele Best, I hope you'll resolve bug 459638 too, which Benjamin closed as WONTFIX once in the past :-)
(Note: I understand why Benjyamin closed that bug as WONTFIX once, but I can't accept WONTFIX of that bug, although I can explain "why Bug 491295 was WONTFIXE'ed/it's reasonable/we should acceptt it" to users and bug openers for similar phenomenon to Bug 491295.)
http://hg.mozilla.org/mozilla-central/rev/0d807039820e
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a1

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0b76e7842754
status1.9.2: --- → final-fixed
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Target Milestone: mozilla1.9.3a1 → mozilla1.9.2
target should stay to the first branch where the patch has been pushed.
Target Milestone: mozilla1.9.2 → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.