531532 - Crash for profiles with a non-existent non-relative profile location

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Gabriele Best [:Gabri]]

Steps to reproduce:

- Download and unzip a trunk build on your desktop
- Make a batch file with ("profile" folder must not exist):
  start C:\......\firefox\firefox.exe -profile profile

Message returned: "Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system.".

Comment 1

[Gabriele Best [:Gabri]]

It should create the "profile" folder automatically or display to the user if he wants to create it.

Comment 2

[Gabriele Best [:Gabri]]

Attachment: proposed patch

It works, I hope benjamin could review it.

Comment 3

[WADA:World Anti-bad-Duping Agency]

Dup of bug 278860?

Comment 4

[Benjamin Smedberg]

No, not at all.

Comment 5

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #4)
> No, not at all.

Benjamin Smedberg, what is difference of this bug from problem of bug 278860?
Proposed patch to this bug never covers problem of bug 278860?
Or you saying that "Firefox is already running, but is not responding. ..." when non-relative path(this bug) is absolutely different problem from the message/phenomenon when relative path(bug 278860)?
Or this bug is really for crash even though Crash-ID is not reported to this bug?

Comment 6

[Gabriele Best [:Gabri]]

This bug is specifically about -profile so it's not a dup of bug 278860.
I'll take a look to bug 278860 soon :)

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 414916 [details] [diff] [review]
proposed patch

a192=beltzner

Comment 8

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #6)
> I'll take a look to bug 278860 soon :)

Gabriele Best, I hope you'll resolve bug 459638 too, which Benjamin closed as WONTFIX once in the past :-)
(Note: I understand why Benjyamin closed that bug as WONTFIX once, but I can't accept WONTFIX of that bug, although I can explain "why Bug 491295 was WONTFIXE'ed/it's reasonable/we should acceptt it" to users and bug openers for similar phenomenon to Bug 491295.)

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/0d807039820e

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0b76e7842754

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

target should stay to the first branch where the patch has been pushed.