531597 - Default bookmarks use "Weave" instead of "Weave Sync"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Francesco Lodolo [:flod]]

Default bookmarks still contain a reference to "Weave" instead of "Weave Sync" (this was fixed for firstrun page in bug 528586).

http://mxr.mozilla.org/mobile-browser/source/locales/en-US/profile/bookmarks.inc#24

Comment 1

[Francesco Lodolo [:flod]]

Any news on this? I've just realized that also the l10n comment needs an update

http://hg.mozilla.org/mobile-browser/file/tip/locales/en-US/profile/bookmarks.inc#l23

https://www.mozilla.com/en-US/mobile/weave is still 404

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 434518 [details] [diff] [review]
Patch

If we change it, we should probably rev the key, too. Unless there's evidence by mxr queries that localizers use Sync in their translated strings anyway (which I doubt, but didn't check).

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

(In reply to comment #3)
> (From update of attachment 434518 [details] [diff] [review])
> If we change it, we should probably rev the key, too. Unless there's evidence
> by mxr queries that localizers use Sync in their translated strings anyway
> (which I doubt, but didn't check).

I've updated the patch, but I've to admit that I don't really know how these stuffs works, so I assume this patch is what you want.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 434561 [details] [diff] [review]
Patch

yep, this looks right.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/b1dd8a914156

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100325 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a3pre) Gecko/20100325 Namoroka/3.7a3pre Fennec/1.1a2pre