531910 - Allow editors to search for completed add-on reviews

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Andreas Wagner [:TheOne] [use NI]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 

Editors need this for better supporting add-on authors about the review on their add-on.

So it would be nice if we could not only search for add-on name and author but also for add-on id.

Reproducible: Always

Comment 1

[Wil Clouser [:clouserw]]

I don't think the title of this bug matches the description.

So, to be clear, this bug is about being able to search for an add-on ID using the queue filtering on the editor queues?

Comment 2

[Andreas Wagner [:TheOne] [use NI]]

Yeah, sorry, that happens if you are non native english speaker.
It's not about searching for done reviews in the queue t(which doesn't make any sense because they aren't in the list anymore).
It's about a way to find done reviews (i.e. der review details page) by name, id etc apart from the queue.

Comment 3

[Wil Clouser [:clouserw]]

You want to be able to go to a Review Details page and have a way to filter the "Item History" section by name, id, and comment.  Is that right?

Comment 4

[Andreas Wagner [:TheOne] [use NI]]

Hm no.

The use case is: an author sent an email to the mailing list regarding the review an editor has done. Now another editor want to have a look at the details page of that add-on, maybe because the author didn't reply to the review email and therefore can't see the text that was entered as response.

Another use case might be: an editor wants to add a comment to an add-on for future reviews either for himself or for other editors.

So what I meant is a search-box _somewhere_ where I can enter add-on id, name, author email etc and when I click the submit button, I get a list with reviewed add-ons that match my searchterm (so the search feature should go through all done reviews). When I click on an entry, I get to the review details page.
It's a bit like the review log, but that log does not have search-box.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Bug 533033 (the editor redesign) would fix this issue by changing the review page URL scheme, but it remains to be seen if all of these changes will be implemented

Comment 6

[Wil Clouser [:clouserw]]

-> jorge for explanation/plans/resolution/etc.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

This was brought up as an important bug to fix in the last AMO Editors meeting. Moving to 5.12.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

One way to implement this is how it is specified in the re-design mockups:
https://bug533033.bugzilla.mozilla.org/attachment.cgi?id=418727

The idea here is that we would add a checkbox to search for resolved reviews. You would be able to enter the add-on name or author email address, just like now. When the checkbox is checked, the query would be performed on all reviews and not only the pending ones. Showing only the latest review per add-on, and showing only one page of results should be enough IMO.

Comment 9

[Wil Clouser [:clouserw]]

The Review Log already has a complete list of past reviews.  Wouldn't this make more sense as a filter on that page?

Comment 10

[Andreas Wagner [:TheOne] [use NI]]

(In reply to comment #9)
> The Review Log already has a complete list of past reviews.  Wouldn't this make
> more sense as a filter on that page?

Yes indeed. I suggest a searchbox with the same functionality as on the review queue pages.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Yes, what we need is to add filtering options for Add-on Name, Editor Name, and Comments (search through all editor comments).

Comment 13

[Gregory Koberger (:gkoberger)]

To clarify:

We just want to add a search box to /en-US/editors/reviewlog, which will search add-on name, editor name and comments?  Separate boxes, or just one box?

Comment 14

[Jorge Villalobos [:jorgev] (he/him)]

Either way works for us. I like the idea of a single search box, though.

Comment 15

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/828ea06

QA: Unless `manage.py commentlog` is run, the comment search will only work for new review actions.

Comment 16

[krupa raj[:krupa]]

verified @ https://addons-next.allizom.org/en-US/editors/reviewlog