532001 - Forum search results contain too many results per page

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[James Socol [:jsocol, :james]]

On page 2 of the results there are 13 per page, on page 3 it's 23. The offset parameter is working, that is: the 11th result on page 2 is the first result on page 3, but too many are being listed.

Looks like the results/page parameter wasn't being passed to SphinxLib::format_results_forums().

Comment 1

[James Socol [:jsocol, :james]]

Attachment: results per page

This just passes SEARCH_RESULTSPERPAGE to SphinxLib::format_results_forums() as the last ($count) parameter.

Paul, please let me know if that's wrong, but it looks like this is the intended behaviour and it just got overlooked.

Comment 2

[Michael Morgan [:morgamic]]

Comment on attachment 415303 [details] [diff] [review]
results per page

Looks good.  Can you file a bug about managing constants and improving/centralizing configs?

Comment 3

[James Socol [:jsocol, :james]]

r57076.

Also filed bug 532004 re: managing constants and configs.

Comment 4

[Paul Craciunoiu [:paulc]]

Attachment: the way i'd do it

James: the fix you added is fine. I attached a patch for how I would do it -- modifying the section of the code that slices available results passing them to be formatted. The result is the same though, so we can keep the current code.

I should note that this bug only occurs when searching where=all, i.e. merging results from kb and forums. Otherwise you never need to limit the results per page, since Sphinx returns them already paginated.

Comment 5

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.