532041 - js_FindDuplicateFormal misinterprets fun->u.i.names union

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

See bug 514580 comment 11 et seq.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: with some trailing whitespace removal

Comment 2

[Brendan Eich [:brendan]]

This strict formal checking looks costly -- under ES5's "use strict" or ye olde JSOPTION_STRICT, every function pays for CheckStrictForamls even though the code earlier in FunctionDef adds one formal at a time to fun->u.i.names and therefore knows right away whether there are any dups.

/be

Comment 3

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/f8d3f3df9691

/be

Comment 4

[Jim Blandy :jimb]

(In reply to comment #2)
> This strict formal checking looks costly -- under ES5's "use strict" or ye olde
> JSOPTION_STRICT, every function pays for CheckStrictForamls even though the
> code earlier in FunctionDef adds one formal at a time to fun->u.i.names and
> therefore knows right away whether there are any dups.

Filed as bug 532421.

Comment 5

[Jim Blandy :jimb]

Test case added; patch and review in bug 532341.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/872dcbf2c9c6

Comment 7

[Bob Clary [:bc] (inactive)]

jimb: you missed a call to reportCompare. It will be automatically orange on jsreftests.

Comment 8

[Jim Blandy :jimb]

(In reply to comment #7)
> jimb: you missed a call to reportCompare. It will be automatically orange on
> jsreftests.

http://hg.mozilla.org/tracemonkey/rev/860a58855453

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/f8d3f3df9691