Closed
Bug 532254
Opened 15 years ago
Closed 15 years ago
TCF_FUN_PARAM_EVAL value collides with another flag
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jimb, Assigned: jimb)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.89 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This is what happens when patches get old and their authors (cough) don't pay attention. Brendan said, in bug 514575 comment 9: ---- This patch added TCF_FUN_PARAM_EVAL but used 0x10000 for its value, which collides with the value of the pre-existing TCF_DECL_DESTRUCTURING macro. Please file and fix, r?mrbkap :-/. /be
|
Assignee | |
Comment 1•15 years ago
|
||
Regression test included.
Assignee: general → jim
Attachment #415546 -
Flags: review?(mrbkap)
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite+
|
||
Updated•15 years ago
|
Attachment #415546 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/7b3d99b0640e
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•15 years ago
|
||
jimb rocks da house!
|
||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b3d99b0640e
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•