514575 - ES5 strict mode: redeclaration of eval or arguments is not permitted

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

From ES5 Annex C:

It is a SyntaxError if a VariableDeclaration or VariableDeclarationNoIn occurs within strict code and its Identifier is eval or arguments (12.2.1).

Comment 1

[Jim Blandy :jimb]

Attachment: Forbid rebinding 'eval' or 'arguments' in ES5 strict mode code.

Comment 6

[Jim Blandy :jimb]

Attachment: Forbid rebinding 'eval' or 'arguments' in ES5 strict mode code.

Now, with tests.  sayrer said he wasn't the right person to review this, so mrbkap gets tagged.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 412439 [details] [diff] [review]
Forbid rebinding 'eval' or 'arguments' in ES5 strict mode code.

+++ b/js/src/jsparse.cpp
@@ -1220,41 +1220,89 @@ CheckStrictAssignment(JSContext *cx, JST
+            js_ReportStrictModeError(cx, TS(tc->compiler), tc, pn,
+                                    JSMSG_BAD_BINDING, name);

Nit: second line is underindented by one space.

Comment 8

[Jim Blandy :jimb]

http://hg.mozilla.org/tracemonkey/rev/ace9ea745215

Comment 9

[Brendan Eich [:brendan]]

This patch added TCF_FUN_PARAM_EVAL but used 0x10000 for its value, which collides with the value of the pre-existing TCF_DECL_DESTRUCTURING macro. Please file and fix, r?mrbkap :-/.

/be

Comment 10

[Jim Blandy :jimb]

(In reply to comment #9)
> This patch added TCF_FUN_PARAM_EVAL but used 0x10000 for its value, which
> collides with the value of the pre-existing TCF_DECL_DESTRUCTURING macro.
> Please file and fix, r?mrbkap :-/.

Filed as bug 532254.

Comment 11

[Brendan Eich [:brendan]]

Fixed in m-c a while ago:

http://hg.mozilla.org/mozilla-central/rev/ace9ea745215

/be