Closed Bug 532751 Opened 10 years ago Closed 10 years ago

Refreshing should try to load a crashed plugin again

Categories

(Core :: Plug-ins, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Whiteboard: [notacrash])

Attachments

(1 file, 1 obsolete file)

When a plugin process crashes, reloading the page should start a new plugin process and reload the plugins. Currently you have to reload twice, because a failing NPP_New will unload the plugin.
Attachment #415949 - Flags: review?(joshmoz)
Attachment #415949 - Flags: review?(bent.mozilla)
I'll have an updated test for this behavior as part of bug 532400 shortly.
Comment on attachment 415949 [details] [diff] [review]
Notify the nsNPAPIPlugin of crashes, rev. 1

The parts I understand look great! ;)
Attachment #415949 - Flags: review?(bent.mozilla) → review+
Whiteboard: [notacrash]
This patch implements what we talked about last week: when a plugin crashes, we walk and remove all the nsPluginInstanceTag associated with the plugin.
Attachment #415949 - Attachment is obsolete: true
Attachment #417295 - Flags: review?(joshmoz)
Attachment #415949 - Flags: review?(joshmoz)
Blocks: 532400
Attachment #415949 - Flags: review-
Attachment #415949 - Flags: review-
Attachment #417295 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/755a66faccf5
http://hg.mozilla.org/mozilla-central/rev/e3016841a7cd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.